Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for resetUserPassword #33151

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for cliProvisioning resetUserPassword using occ commands.

Related issue: #33052

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paurakhsharma paurakhsharma force-pushed the occTest-cliProvisioning-resetUserPassword branch from 7d7111d to e79beb4 Compare October 11, 2018 08:04
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #33151 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33151   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18720    18720           
=========================================
  Files          1184     1184           
  Lines         70437    70437           
  Branches       1270     1270           
=========================================
  Hits          45171    45171           
  Misses        24896    24896           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 18720 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca99950...e79beb4. Read the comment docs.

@paurakhsharma paurakhsharma merged commit 2e509c6 into master Oct 11, 2018
@paurakhsharma paurakhsharma deleted the occTest-cliProvisioning-resetUserPassword branch October 11, 2018 08:36
@paurakhsharma
Copy link
Member Author

Backport on: #33153

@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants