Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliTest user settings #33250

Merged
merged 1 commit into from
Oct 24, 2018
Merged

cliTest user settings #33250

merged 1 commit into from
Oct 24, 2018

Conversation

paurakhsharma
Copy link
Member

Description

This PR adds more tests for cliProvisioning userSettings using occ commands.

Related issue: #33052

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #33250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33250   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18276    18276           
=========================================
  Files          1190     1190           
  Lines         69047    69047           
  Branches       1271     1271           
=========================================
  Hits          44234    44234           
  Misses        24443    24443           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (ø) 18276 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622666f...c5b05b5. Read the comment docs.

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please only merge after #33244 and #33246 have been merged

@paurakhsharma paurakhsharma force-pushed the cliTest-userSettings branch 3 times, most recently from 2d4d3d9 to 415923a Compare October 23, 2018 07:00
@phil-davis
Copy link
Contributor

Looks good, but needs rebase and resolving conflicts.

@phil-davis phil-davis merged commit 9250b69 into master Oct 24, 2018
@phil-davis phil-davis deleted the cliTest-userSettings branch October 24, 2018 07:14
@paurakhsharma
Copy link
Member Author

Backport on: #33278

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants