Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File cache hole check only report storage id once #33468

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 9, 2018

Description

Fix file cache repair check to only output the storage id once instead
of multiple times.

Related Issue

Motivation and Context

Because having the same value multiple times is not readable.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Fix file cache repair check to only output the storage id once instead
of multiple times.
@PVince81 PVince81 force-pushed the fix-repair-filecache-check-output branch from dbdc8b0 to a7e3715 Compare November 9, 2018 15:59
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #33468 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33468      +/-   ##
============================================
+ Coverage     64.07%   64.12%   +0.04%     
  Complexity    18315    18315              
============================================
  Files          1192     1192              
  Lines         69167    69169       +2     
  Branches       1277     1277              
============================================
+ Hits          44322    44353      +31     
+ Misses        24473    24444      -29     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <100%> (+0.04%) 18315 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair/RepairMismatchFileCachePath.php 96.88% <100%> (+11.39%) 51 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca67d6...a7e3715. Read the comment docs.

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PVince81 PVince81 merged commit 81d5e68 into master Nov 15, 2018
@PVince81 PVince81 deleted the fix-repair-filecache-check-output branch November 15, 2018 12:42
@PVince81
Copy link
Contributor Author

stable10: #33539

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove duplicated storages while checking the filecache corruption
2 participants