-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve uploading file in chunks #33692
Conversation
$size = \filesize( | ||
$this->acceptanceTestsDirLocation() . $source | ||
PHPUnit_Framework_Assert::assertGreaterThan( | ||
0, $noOfChunks, "What does it mean to have $noOfChunks chunks?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future data compression algorithm that can fit the whole file content into 0 chunks ;)
research project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its all there https://github.com/philipl/pifs
πfs is a revolutionary new file system that, instead of wasting space storing your data on your hard drive, stores your data in π! You'll never run out of space again - π holds every file that could possibly exist! They said 100% compression was impossible? You're looking at it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It broke:
|
1c5418f
to
f02b841
Compare
should be fixed now |
backport in #33694 |
Codecov Report
@@ Coverage Diff @@
## master #33692 +/- ##
=========================================
Coverage 64.34% 64.34%
Complexity 18305 18305
=========================================
Files 1195 1195
Lines 69228 69228
Branches 1276 1276
=========================================
Hits 44548 44548
Misses 24308 24308
Partials 372 372
Continue to review full report at Codecov.
|
Description
improve the step that does split a file and uploads it in chunks
Related Issue
Motivation and Context
be able to do https://github.com/owncloud/files_classifier/issues/114
Types of changes
Checklist:
Open tasks: