Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing insulated disablePreviews tags to webUI feature files #34715

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

phil-davis
Copy link
Contributor

Description

While investigating issue #34689 I noticed that some webUI feature files did not have the "standard" tags:
insulated - behat-mink-selenium will restart the browser between each scenario - gives better isolation
disablePreviews - when not doing tests that check for previews display, avoids the slowness of previews being constantly generated and slowly drawing up on the UI (not always directly relevant to particular tests, but does reduce the "noise" as the test logs in and the files page is displayed)

Make all the webUI feature files consistent. And it might help the issue.

Related Issue

#34689

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #34715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34715   +/-   ##
=========================================
  Coverage     65.28%   65.28%           
  Complexity    18481    18481           
=========================================
  Files          1210     1210           
  Lines         69984    69984           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23924    23924           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0f23f...e10a372. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #34716

@phil-davis phil-davis merged commit a93e321 into master Mar 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the tags-insulated-disablePreviews branch March 8, 2019 09:03
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants