Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiTest for share with only membership groups #35733

Merged
merged 1 commit into from
Jul 2, 2019
Merged

apiTest for share with only membership groups #35733

merged 1 commit into from
Jul 2, 2019

Conversation

paurakhsharma
Copy link
Member

Description

Add tests for shareapi_only_share_with_membership_groups parameter.

Related Issue

#35673

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma self-assigned this Jul 2, 2019
dpakach
dpakach reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma paurakhsharma merged commit f60d4aa into master Jul 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the test-only-member-share branch July 2, 2019 11:10
@paurakhsharma paurakhsharma mentioned this pull request Jul 2, 2019
Merged
@paurakhsharma
Copy link
Member Author

Backport on: #35740

@phil-davis phil-davis mentioned this pull request Jul 8, 2019
Open
4 tasks
@PVince81 PVince81 mentioned this pull request Jul 8, 2019
Open
22 tasks
@paurakhsharma paurakhsharma mentioned this pull request Jul 8, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis approved these changes

@skshetry skshetry Awaiting requested review from skshetry

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@paurakhsharma paurakhsharma

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paurakhsharma @phil-davis @dpakach