Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Acceptance tests when incoming and outgoing federated share settings are enabled or disabled #37106

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Mar 11, 2020

Description

Add acceptance tests for different permutations of incoming and outgoing federated share settings enabled or disabled

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #37106 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37106   +/-   ##
=========================================
  Coverage     64.78%   64.78%           
  Complexity    19133    19133           
=========================================
  Files          1270     1270           
  Lines         74914    74914           
  Branches       1328     1328           
=========================================
  Hits          48531    48531           
  Misses        25993    25993           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.96% <ø> (ø) 19133.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f348e...568c66f. Read the comment docs.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can combine all these scenarios into outline.

tests/acceptance/features/apiFederation/federated.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/FederationContext.php Outdated Show resolved Hide resolved
@jasson99 jasson99 force-pushed the permutationsForIncomingOutgoingFederationShares branch from 17ad7e4 to 568c66f Compare March 12, 2020 08:22
@phil-davis phil-davis merged commit ce294a8 into master Mar 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the permutationsForIncomingOutgoingFederationShares branch March 13, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federation acceptance tests should test incoming and outgoing separately
5 participants