Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] enhance theWebdavChecksumShouldMatch test #39708

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 24, 2022

Description

https://drone.owncloud.com/owncloud/ocis/8908/23/6 fails with:
Warning: Illegal string offset 'value' in /srv/app/testrunner/tests/acceptance/features/bootstrap/ChecksumContext.php line 204

  1. The PROPFIND response does not have the expected structure. The test code assumes that the deep array structure of the PROPFIND will all exist, and that it will be able to directly find the checksum.

This PR enhances the test code so that it checks at every level of the expected structure and fails with a message as soon as it discovers part of the nested structure does not exist.

  1. some tests were added to core for "deep move" in PR [tests-only] Test moving a folder into a sub-folder of itself #39705 - those need to be skipped when testing against an "old" oC10, because the fix is only in master, not in 10.9.1 release or earlier.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 24, 2022
@phil-davis phil-davis marked this pull request as ready for review January 24, 2022 05:59
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit c190a8a into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the enhance-theWebdavChecksumShouldMatch branch January 24, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants