Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] added spaces examples for TUS related upload features #39723

Merged
merged 1 commit into from
Feb 1, 2022
Merged

[tests-only] added spaces examples for TUS related upload features #39723

merged 1 commit into from
Feb 1, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jan 27, 2022 •
edited
Loading

Description

  • use spaces DAV variant for TUS related upload features

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589 kiranparajuli589 force-pushed the tus-upload-with-spaces branch 2 times, most recently from 0a9d49a to ddff349 Compare January 27, 2022 12:08
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jan 27, 2022
Merged
@kiranparajuli589 kiranparajuli589 self-assigned this Jan 28, 2022
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review January 28, 2022 09:43
individual-it
individual-it requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the @skipOnOc10 tags. Do we still need them?

tests/acceptance/features/bootstrap/ChecksumContext.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
@kiranparajuli589
Copy link
Contributor Author

I'm missing the @skipOnOc10 tags. Do we still need them?

all of the features in apiWebdavUploadTUS suites already have @skipOnOcV10 tag at top

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioning-v1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/54/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiMain-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/53/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFavorites-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/52/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareReshareToRoot3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/77/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/75/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavUpload1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/98/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-10.8.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/104/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareManagementToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/63/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareOperationsToShares2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/70/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavMove2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/93/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareUpdateToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/79/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot2-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/106/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/102/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot2-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/105/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToRoot2-10.8.0-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/107/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAdminSettings-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/126/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIAddUsers-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34463/125/1

individual-it
individual-it requested changes Jan 31, 2022
View reviewed changes
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34464/172/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34466/172/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiSharePublicLink1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34476/71/1

@kiranparajuli589 kiranparajuli589 force-pushed the tus-upload-with-spaces branch 2 times, most recently from a60fca0 to 96914c4 Compare February 1, 2022 06:05
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliBackground-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34478/114/1

@kiranparajuli589 kiranparajuli589 marked this pull request as draft February 1, 2022 06:09
phil-davis
phil-davis approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There have been other PRs merged to master this morning, so you might like to rebase this and let CI run, just to be sure that everything is OK. Then merge.

@phil-davis
Copy link
Contributor

@kiranparajuli589 you can mark "Ready for Review" and merge when you are ready. Then make the next oCIS commit id bump.

@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review February 1, 2022 08:49
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

"This branch is 1 commit ahead of master. " - looks good.

@kiranparajuli589
Copy link
Contributor Author

test PR passed https://drone.owncloud.com/owncloud/ocis/9059

@kiranparajuli589 kiranparajuli589 merged commit fffad64 into master Feb 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the tus-upload-with-spaces branch February 1, 2022 09:55
@phil-davis phil-davis mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use space dav path for TUS upload tests
5 participants
@kiranparajuli589 @ownclouders @phil-davis @individual-it @amrita-shrestha