Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add then step to apiWebdavUploadTUS suite #39812

Merged
merged 1 commit into from
Feb 21, 2022
Merged

[tests-only][full-ci]Add then step to apiWebdavUploadTUS suite #39812

merged 1 commit into from
Feb 21, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 21, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiWebdavUploadTUS

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Feb 21, 2022
@SagarGi SagarGi mentioned this pull request Feb 21, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit afae230 into master Feb 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiWebdavUploadTUS branch February 21, 2022 11:34
@SagarGi SagarGi mentioned this pull request Feb 22, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarGi @phil-davis @kiranparajuli589