Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiWebdavProperties suites #39819

Merged
merged 2 commits into from
Feb 23, 2022
Merged

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiWebdavProperties suites #39819

merged 2 commits into from
Feb 23, 2022

Conversation

grgprarup
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiWebdavProperties1
  • apiWebdavProperties2

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup self-assigned this Feb 22, 2022
@grgprarup grgprarup mentioned this pull request Feb 22, 2022
Closed
saw-jan
saw-jan reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup force-pushed the improve-then-steps-in-apiWebdavProperties branch from a8a5acb to aa135f2 Compare February 22, 2022 09:13
@grgprarup grgprarup force-pushed the improve-then-steps-in-apiWebdavProperties branch from e724e4a to 9e72c32 Compare February 22, 2022 10:28
@grgprarup grgprarup force-pushed the improve-then-steps-in-apiWebdavProperties branch from 9e72c32 to e681248 Compare February 22, 2022 10:41
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

amrita-shrestha
amrita-shrestha reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis merged commit bc0748f into master Feb 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiWebdavProperties branch February 23, 2022 04:13
@grgprarup grgprarup mentioned this pull request Feb 23, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@saw-jan saw-jan saw-jan left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@Talank Talank Awaiting requested review from Talank

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@sushmita56 sushmita56 Awaiting requested review from sushmita56

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grgprarup @phil-davis @kiranparajuli589 @saw-jan @amrita-shrestha