Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add then step to suites apiSharePublicLink(1 and 2) #39853

Merged
merged 3 commits into from
Mar 11, 2022
Merged

[tests-only][full-ci]Add then step to suites apiSharePublicLink(1 and 2) #39853

merged 3 commits into from
Mar 11, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Mar 7, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiSharePublicLink1
  • apiSharePublicLink2

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi added the QA:team label Mar 7, 2022
@SagarGi SagarGi self-assigned this Mar 7, 2022
@SagarGi SagarGi mentioned this pull request Mar 7, 2022
Closed
@SagarGi SagarGi force-pushed the apiSharePublicLink branch 2 times, most recently from 63b01a6 to 54a16fc Compare March 10, 2022 06:29
@SagarGi SagarGi requested a review from SwikritiT March 10, 2022 08:09
@SagarGi SagarGi marked this pull request as ready for review March 10, 2022 08:09
@kiranparajuli589
Copy link
Contributor

build failed at coding-standard https://drone.owncloud.com/owncloud/core/34870/3/6

kiranparajuli589
kiranparajuli589 reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 merged commit 124475d into master Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiSharePublicLink branch March 11, 2022 04:33
@sushmita56 sushmita56 mentioned this pull request Mar 11, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @kiranparajuli589 @phil-davis @SwikritiT