[tests-only] Make LDAP based test config more flexible for being able to run with libregraph/idm default config #39893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rhafer GitHub claims that you have not signed the CLA yet? Please click the button... |
phil-davis
reviewed
Mar 17, 2022
|
https://drone.owncloud.com/owncloud/core/34961/3/6 |
rhafer
force-pushed
the
ldapsettings
branch
2 times, most recently
from
37b0dab
to
60a6e0f
Compare
|
💥 Acceptance tests pipeline webUICreateDelete-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
phil-davis
approved these changes
Mar 21, 2022
|
@rhafer feel free to merge if this is ready from your PoV. |
|
@phil-davis Thanks. Will do. I still need to re-run this once more against reva, to make sure it doesn't break anything there. |
rhafer
force-pushed
the
ldapsettings
branch
3 times, most recently
from
d64194a
to
238b45a
Compare
The "ou" values for Test Users and Groups and the baseDN are defined via config. Remove the hardcoded references to "dc=owncloud,dc=com" and "ou=TestUsers/Groups" from the code.
This introduces two new env setttings: REVA_LDAP_USESSL and REVA_LDAP_BIND_PASSWORD. Set REVA_LDAP_USESSL to true to be able to force the usage of LDAPS even when not running on the standard port (636). REVA_LDAP_BIND_PASSWORD can be used to override the LDAP bind password. The purpose of this change is to be able to test against exiting LDAP servers and the embeded libregraph-idm that is deployed be the default configuration in ocis.
This is merely a cosmetic change and the attribute is already used as the naming attribute in the users's DN (thus set implicitly). This is just making things explicit and visible.
In order to be a bit more flexible when testing against libregraph-idm introduce the new variable REVA_LDAP_SKIP_LDIF_IMPORT to allow to skip the import of the base LDIF file that creates the ou objects for users and groups (these objects are already present in such a setup). This also means that when removing users and groups after each test we cannot rely on recursivly removing the ou object about explicitly delete every user/group.
The objectclasses "person", "organizationalPerson" and "top" are valid for all setups (alternatively they could be left out as they are implicitly added via inheritance) When testing against oCIS alway add the "owncloud" objectclass and the "owncloudUUID" attribute independent of the parallel deployment setting.
This allows to switch between different types of LDAP Groups. The default behaviour (REVA_LDAP_GROUP_SCHEMA="rfc2307") is to use the "posixGroup" objectclass with "memberUID" attribute. Any other value for REVA_LDAP_GROUP_SCHEMA will switch the behaviour to objectclass "groupOfNames" and the "member" Attribute.
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a couple of new LDAP related settings (via enviroment variables) in order to be able to run the LDAP based testsuite against the default libregraph-idm configuration as created by ocis (see: owncloud/ocis#3331). Those settings can also be useful when testing ocis against different LDAP setups.
Motivation and Context
To provide more flexibility when testing oCIS with and LDAP backend.
How Has This Been Tested?
Types of changes