Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] use graph api to create/delete users for the acceptance tests #39927

Merged
merged 16 commits into from
Apr 13, 2022
Merged

[tests-only] use graph api to create/delete users for the acceptance tests #39927

merged 16 commits into from
Apr 13, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Mar 28, 2022 •
edited
Loading

Description

Related

@kiranparajuli589 kiranparajuli589 force-pushed the use-graph-helper-from-ocis branch 4 times, most recently from 5e27b8d to 7827d63 Compare March 31, 2022 10:08
@ownclouders
Copy link
Contributor

ownclouders commented Mar 31, 2022 •
edited
Loading

💥 Acceptance tests pipeline apiShareCreateSpecialToShares1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35279/59

@kiranparajuli589 kiranparajuli589 force-pushed the use-graph-helper-from-ocis branch 8 times, most recently from 18a8844 to ba6aaa7 Compare April 6, 2022 15:19
@kiranparajuli589 kiranparajuli589 changed the title [tests-only] run ci with graph api enabled for users/group provisioning [tests-only] use graph api to create/delete users for the acceptance tests Apr 8, 2022
@kiranparajuli589 kiranparajuli589 mentioned this pull request Apr 8, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Apr 8, 2022
Closed
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review April 11, 2022 10:30
@kiranparajuli589 kiranparajuli589 self-assigned this Apr 11, 2022
@micbar
Copy link
Contributor

micbar commented Apr 11, 2022

owncloud/ocis#3507 was merged. should be unblocked now.

@kiranparajuli589
use graph helper for user provisioning
88aa614 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Add user to group
f5bc727 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
moved isTestingWithGraphApi fn to ocisHelper and use the GraphHelper …
9bb0f1f 
…only if testing with graph API

Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
provisioning upto 5151
972dc94 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
More changes 1:
7f5ad6e 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Added local graph context
fb948c5 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
use context from ocis
6cecc8b 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
Fix addUserToCreatedUsersList calls
5bb3e61 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
Skipped provisioning tests for graph
8f255e3 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Refactor get attributes fn to throw exceptions
f80f016 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
Only load ocis helpers if PATH_TO_OCIS is set to a valid directory
d38920a 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Addressed reviews
0b7c4f8 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Skipped more scenarios related to oics issue 3483
f34b528 
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589
Copy link
Contributor Author

tests that crashes ocis server because of owncloud/ocis#3483 are skipped in this PR.

individual-it
individual-it requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big accomplishment!
Just minor comments

tests/acceptance/features/bootstrap/Provisioning.php Show resolved Hide resolved
tests/acceptance/features/bootstrap/Provisioning.php Show resolved Hide resolved
tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved
@kiranparajuli589
Addressed reviews
9933520 
Signed-off-by: Kiran Parajuli <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ScharfViktor
ScharfViktor approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool work))

@kiranparajuli589 kiranparajuli589 merged commit e98e41f into master Apr 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the use-graph-helper-from-ocis branch April 13, 2022 08:51
@kiranparajuli589
Copy link
Contributor Author

the commit id will be bumped in owncloud/ocis#3404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@individual-it individual-it individual-it approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kiranparajuli589 @ownclouders @micbar @individual-it @saw-jan @ScharfViktor