Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Improve Then step in apiShareReshareToShares3 suite #39965

Merged
merged 2 commits into from
Apr 22, 2022
Merged

[tests-only][full-ci] Improve Then step in apiShareReshareToShares3 suite #39965

merged 2 commits into from
Apr 22, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of the When steps.

Suites covered:

  • improveThenStepInApiShareReshareToShare3

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Apr 8, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 8, 2022
Closed
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 8, 2022 06:34
kiranparajuli589
kiranparajuli589 reviewed Apr 8, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareReshareToShare3 branch from 05841b3 to 8247b4d Compare April 13, 2022 04:18
@amrita-shrestha amrita-shrestha marked this pull request as draft April 13, 2022 04:25
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareReshareToShare3 branch from 8247b4d to 3675d80 Compare April 19, 2022 05:23
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 19, 2022 05:23
SagarGi
SagarGi reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SwikritiT
SwikritiT reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enforce-expire-date is set to yes for all so maybe we don't need to put it in example table, we can put that directly in step in line 67. Similar for other example tables too

core/tests/acceptance/features/apiShareReshareToShares3/reShareWithExpiryDate.feature

Lines 84 to 89 in 3675d80

Examples:
| ocs_api_version | default-expire-date | enforce-expire-date | expected-expire-date | ocs_status_code |
| 1 | yes | yes | +30 days | 100 |
| 2 | yes | yes | +30 days | 200 |
| 1 | no | yes | | 100 |
| 2 | no | yes | | 200 |

@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareReshareToShare3 branch from 3675d80 to 8908917 Compare April 21, 2022 09:33
@kiranparajuli589 kiranparajuli589 force-pushed the improveThenStepInApiShareReshareToShare3 branch from 8908917 to 6459cc2 Compare April 22, 2022 04:54
SwikritiT
SwikritiT reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 89f253e into master Apr 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the improveThenStepInApiShareReshareToShare3 branch April 22, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @phil-davis @kiranparajuli589 @SwikritiT @SagarGi