Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Improve Then step in apiShareUpdateToRoot suite #39969

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[tests-only][full-ci] Improve Then step in apiShareUpdateToRoot suite #39969

merged 1 commit into from
Apr 13, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of the When steps.

Suites covered:

  • apiShareUpdateToRoot

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Apr 11, 2022
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareUpdateToRoot branch from e742ad8 to 67e4f37 Compare April 11, 2022 09:59
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareUpdateToRoot branch from 67e4f37 to 25f6499 Compare April 13, 2022 02:19
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 13, 2022 03:14
kiranparajuli589
kiranparajuli589 reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@individual-it individual-it merged commit db6f7b8 into master Apr 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the improveThenStepInApiShareUpdateToRoot branch April 13, 2022 08:07
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrita-shrestha @individual-it @kiranparajuli589