Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added webdav spaces in apiTrashbin suite #39982

Merged
merged 6 commits into from
Apr 28, 2022
Merged

[tests-only][full-ci] Added webdav spaces in apiTrashbin suite #39982

merged 6 commits into from
Apr 28, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Apr 19, 2022 •
edited
Loading

Description

Added Spaces examples for features inside suite apiTrashbin
Files covered:

  • trashbinDelete.feature
  • trashbinFilesFolders.feature
  • trashbinFilesFoldersOc10Issue23151.feature
  • trashbinSharingToRoot.feature
  • trashbinSharingToShares.feature
  • trashbinSkip.feature

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup force-pushed the add-spaces-for-apiTrashbin-suite branch from b6e7379 to 180d613 Compare April 22, 2022 05:21
@grgprarup grgprarup changed the title [tests-only][full-ci] Added webdav spaces in apiTrashbin/trashbinDelete.feature [tests-only][full-ci] Added webdav spaces in apiTrashbin suite Apr 27, 2022
@grgprarup grgprarup force-pushed the add-spaces-for-apiTrashbin-suite branch 3 times, most recently from d862f02 to abafe1d Compare April 27, 2022 08:59
@grgprarup grgprarup self-assigned this Apr 27, 2022
@grgprarup grgprarup marked this pull request as ready for review April 27, 2022 09:51
amrita-shrestha
amrita-shrestha reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup force-pushed the add-spaces-for-apiTrashbin-suite branch from 652aacd to 676850b Compare April 28, 2022 06:45
kiranparajuli589
kiranparajuli589 reviewed Apr 28, 2022
View reviewed changes
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
tests/TestHelpers/WebDavHelper.php Outdated Show resolved Hide resolved
@grgprarup grgprarup force-pushed the add-spaces-for-apiTrashbin-suite branch from 676850b to bf5c7d0 Compare April 28, 2022 07:16
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit bd089ba into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-spaces-for-apiTrashbin-suite branch April 28, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

@SagarGi SagarGi Awaiting requested review from SagarGi

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grgprarup @phil-davis @kiranparajuli589 @amrita-shrestha