Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps in apiShareCreateSpecialToShares2 suite #40019

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[tests-only][full-ci]Improve then steps in apiShareCreateSpecialToShares2 suite #40019

merged 1 commit into from
Apr 28, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiShareCreateSpecialToShare2

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Apr 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sushmita56 sushmita56 self-assigned this Apr 26, 2022
@sushmita56 sushmita56 marked this pull request as draft April 26, 2022 08:52
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToShares2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35445/61

@sushmita56 sushmita56 changed the title improved then steps [tests-only][full-ci]Improve then steps in apiShareCreateSpecialToShares2 suite Apr 26, 2022
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares2 branch from 8b7f0c5 to 41883fa Compare April 26, 2022 09:47
@sushmita56 sushmita56 marked this pull request as ready for review April 26, 2022 09:49
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares2 branch from 41883fa to 9bd7d38 Compare April 27, 2022 03:45
SagarGi
SagarGi reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

...ce/features/apiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature Outdated Show resolved Hide resolved
@sushmita56 sushmita56 mentioned this pull request Apr 27, 2022
Closed
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares2 branch 2 times, most recently from 34638a2 to 44ed45f Compare April 27, 2022 05:26
@sushmita56 sushmita56 requested a review from SagarGi April 27, 2022 05:28
kiranparajuli589
kiranparajuli589 reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

amrita-shrestha
amrita-shrestha reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amrita-shrestha
amrita-shrestha reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In https://github.com/owncloud/core/pull/40019/files#diff-928e247b07ec61609dd5d232ea057e0b2ba164351c38297bb0fe6e1857feafd1R106-R108

      | ocs_api_version | ocs_status_code | http_status_code |
      | 1                         | 100                      | 200                      |
      | 2                         | 200                      | 200                      |

I think we can remove http_status_code from table as it provide same status code '200'

@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares2 branch from 44ed45f to 47cdcbb Compare April 27, 2022 11:25
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit d8dee24 into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiShareCreateSpecialToShares2 branch April 28, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sushmita56 @ownclouders @phil-davis @kiranparajuli589 @SagarGi @amrita-shrestha