Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Improve Then step in apiShareManagementToRoot suites #40022

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[tests-only][full-ci] Improve Then step in apiShareManagementToRoot suites #40022

merged 1 commit into from
Apr 28, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of the When steps.

Suites covered:

  • apiShareManagementToRoot

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Apr 27, 2022
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 27, 2022
Closed
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareManagementToRoot branch 2 times, most recently from 3c6aebc to 1a4841b Compare April 27, 2022 07:54
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 27, 2022 09:32
SagarGi
SagarGi reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 👍

tests/acceptance/features/apiShareManagementToRoot/moveShareInsideAnotherShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareManagementToRoot/mergeShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareManagementToRoot/mergeShare.feature Outdated Show resolved Hide resolved
@kiranparajuli589
Copy link
Contributor

lgtm 👍

@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareManagementToRoot branch 2 times, most recently from 49385f7 to 72395df Compare April 28, 2022 03:45
@phil-davis
Copy link
Contributor

@amrita-shrestha please rebase - GitHub reports conflicts

@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiShareManagementToRoot branch from 72395df to c97e193 Compare April 28, 2022 07:56
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 397a602 into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the improveThenStepInApiShareManagementToRoot branch April 28, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@SagarGi SagarGi Awaiting requested review from SagarGi

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @kiranparajuli589 @phil-davis @SagarGi