[tests-only][full-ci]Adjustment in core so that code can be reused from ocis #40327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
force-pushed
the
refactorInCoreForCodeReuseInOcis
branch
from
14ff2d0
to
12cb2a6
Compare
SagarGi
force-pushed
the
refactorInCoreForCodeReuseInOcis
branch
from
12cb2a6
to
3acff92
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
SagarGi
requested review from
grgprarup,
SwikritiT,
individual-it,
phil-davis and
saw-jan
11 tasks
|
Closing this issue after making this PR #40328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some code adjustment (in core) so that the code can be reused in ocis (If any new implementation is done). Since as of now we are duplicating the same code in core as well as in ocis.
We have a
favourite.featurefeature in ocis where we have been duplicating code so for reference i have tried to reduce the code inocisfor the feature so that it uses code (resource) already in core (for reducing code duplication). Follow this PR owncloud/ocis#4492Related Issue
No related Issue So far since this is a sample PR (After approval) a separate issue is made for refactoring and code reuse from core for ocis implementation.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: