[Work in Progress] Do not download files that are too big via "From Link".

[bantu]

Work in Progress patch for #5398

[tanghus]

You do a lot of work instead of OC::$server->getRequest()->getHeader('Content-Length'); 😉

[DeepDiver1975]

@bantu while you are touching that code pieces - please consider fixing #5406 as well - THX

[bantu]

@tanghus You are mistaken. This is about the HTTP response headers for "new file from link".

[tanghus]

You are mistaken. This is about the HTTP response headers for "new file from link".

@bantu I was too fast. Your approach might be good. There must be a wrapper for this, but lets wait with that until oC7 and just keep this out of the public API :)

[bantu]

@tanghus I agree this may be better for ownCloud 7. @karlitschek
@DeepDiver1975 Oh, sure. Thanks for the typo fixes, btw.

[karlitschek]

agreed. ownCloud 7

[bantu]

Could probably use \Symfony\Component\HttpFoundation\ResponseHeaderBag instead of reinventing the wheel here.

[tanghus]

Damn, we would have been a lot further by now if we had started on a Symfony foundation. Last time I coded PHP the only other "frameworks" I knew of, were the ones I'd coded myself :D

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2454/

[DeepDiver1975]

@bantu is this still WIP or ready for test? THX

[bantu]

@DeepDiver1975 Just rebased this yesterday. Need to have a closer look again.

[bantu]

This should have #7123 merged first (which is a change into the direction this needs to go refactoring wise, with possibly more to come) and the fix here should be extended to include #3614, #1198 and possibly #5398.

[bantu]

Unfortunately \Symfony\Component\HttpFoundation\ResponseHeaderBag does not accept the format that we are receiving from the PHP stream framework. So reusing ResponseHeaderBag may be a bit more complicated.

[bantu]

I am closing this because a similar patch has been merged. See #10290

[jancborchardt]

@bantu remember to delete unneeded branches.

[bantu]

@jancborchardt Thanks. I would like to keep it somewhere, though. Pushed to bantu now.

[jancborchardt]

Yeah, please do that on personal space. The branch list is very long and it’s difficult to judge which ones are important and which not.