Icon improvements

[jancborchardt]

• thinner add icon
• improve close icons, more clear shape
• improve upload icon, see Upload button "Up arrow" confusing, looks like "Go to parent dir" #4479, cc @PVince81
• improve download icon, more clear shape
• use trash symbol as delete icon to differentiate from close, cc @schiesbn @tanghus

Please review @owncloud/designers @stefan-niedermann

[scrutinizer-notifier]

A new inspection was created.

[karlitschek]

uuhh. Sweet. The "delete" icon might be more difficult to recognize then the old one. But the rest is awesome. What do you think?
👍

[stefan-niedermann]

👍

download

what do you think about adding a ellipse (like a shadow), line or box on the download-button to make clear, its not a "expand"-arrow?

add

the add-icon is a bit too thin imho - is it possible to find a midway with only 16px?

[jancborchardt]

@karlitschek the »trash« icon is very widely used even in web apps by now, so I think it’s perfectly fine. Also it’s very important that close and delete are different. Btw can you add @stefan-niedermann to the @owncloud/designers team? Thanks! :)

@stefan-niedermann:

• download icon: I think the arrow down is clear enough as download. There’s nothing to expand there.
• add icon: I think it fits the size and thickness of the text. That is important for the add icon in particular because most of the time it will be accompanied by a list item with text

[MorrisJobke]

@jancborchardt Can you remove the metadata?

[MorrisJobke]

@jancborchardt Nevermind, I will test it and remove the metadata ;)

[MorrisJobke]

Fixed and looks good 👍

[jancborchardt]

Merging as Jenkins doesn’t know about icons.

[tanghus]

use trash symbol as delete icon to differentiate from close,

😸

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4448/

[ghost]

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4449/

[karlitschek]

@jancborchardt done

[jancborchardt]

@tanghus what do you mean by that smiley? ;)

[jancborchardt]

@karlitschek thank you!

@stefan-niedermann welcome to @owncloud/designers – now you can use that handle to summon the other designers. Remember that it mentions 8 other people: https://github.com/orgs/owncloud/teams/designers

[tanghus]

@jancborchardt I thought you mentioned me there because I suggested it long time ago? It was - shall we say... an agreeing smiley ;)

[jancborchardt]

@tanghus hehe, right. Thank you then! ;)