Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SSL proxy support #9

Closed
wants to merge 1 commit into from

Conversation

herbrechtsmeier
Copy link
Contributor

Add support for a SSL proxy that handles multiple domains via host name
as prefix in the request URI (https://ssl-proxy.tld/domain.tld/).

As the SSL proxy is transparent for the web server the REQUEST_URI and
SCRIPT_NAME need manual adjustments. This patch replace the direct use
of this _SERVER variables with function calls and extend this functions
to detect the proxy and to add the needed prefix. Additionally it adds
a Sabre request backend with extends the Sabre_HTTP_Request to use the
same functions.

http://bugs.owncloud.org/thebuggenie/owncloud/issues/oc-890

Add support for a SSL proxy that handles multiple domains via host name
as prefix in the request URI (https://ssl-proxy.tld/domain.tld/).

As the SSL proxy is transparent for the web server the REQUEST_URI and
SCRIPT_NAME need manual adjustments. This patch replace the direct use
of this _SERVER variables with function calls and extend this functions
to detect the proxy and to add the needed prefix. Additionally it adds
a Sabre request backend with extends the Sabre_HTTP_Request to use the
same functions.
@LukasReschke
Copy link
Member

Thanks!

Just as an information for you: We're currently in the hard feature freeze for 4.5 which will last until the release of 4.5. This means that we're currently not allowed to commit new features. I'm sure someone will take a look at it, after the release of 4.5 :-)

@bartv2
Copy link
Contributor

bartv2 commented Sep 13, 2012

The code looks good, maybe it could be split in 2 commits. But it is fine like this, ping me after the release of 4.5 if i forgot to merge this.

@ghost ghost assigned bartv2 Sep 24, 2012
@DeepDiver1975
Copy link
Member

@herbrechtsmeier: I'll close this merge request and kindly ask you to resubmit this pull request on basis of the current master.
Something was changed during the past month which prevents automatic merge.

THX a lot

@ghost ghost mentioned this pull request Jul 23, 2014
@carboneater carboneater mentioned this pull request Jul 30, 2014
bhawanaprasain pushed a commit to JankariTech/core that referenced this pull request Apr 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants