ownCloud users are exported as address book

[DeepDiver1975]

alternative approach for #8951

@LEDfan

[LEDfan]

Nice! Works as expected. The difference with #8951 is only that these contacts aren't accessible via the contacts app. Which isn't needed since they can't be edited.

[DeepDiver1975]

The difference with #8951 is only that these contacts aren't accessible via the contacts app. Which isn't needed since they can't be edited.

They should as long as the contacts app is using the contacts manager to access all addressbook

[LEDfan]

Indeed, but this isn't the case. The contacts app runs the getContacts and getAddressbook and getContact methods on the classes defined here: ttps://github.com/owncloud/contacts/blob/master/lib/app.php#L57-L60

[DeepDiver1975]

hehe - this actually explains why there was that much code in your PR 😉

[LEDfan]

Indeed. But I like this :)
Tested 👍

[DeepDiver1975]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/6241/

[DeepDiver1975]

I will add some unit tests the next days

[jancborchardt]

So after some small changes in the Contacts app, this will work for the Contacts app too?

[jancborchardt]

cc @enoch85 here as he was active in the preceding pull request: #8951

[LEDfan]

@jancborchardt this PR #9641 won't load the contacts in the Contacts app. I don't think it's a small adjustment in the Contacts app since it's the core function and design of the Contacts app.

[jancborchardt]

Ok so the goal of this localUsers backend is to have an easy way to expose the local users to apps like Contacts and Chat. Is this achieved by this PR? Or what does this do? :)

[LEDfan]

@jancborchardt this PR is an alternative for #8951.
The Contacts can be fetched by every app on the same way as in #8951.(i.e. via the ContactsManager) The contacts app fetches the contacts by calling the getContacts() method on a Contacts backend. The thing is this PR doesn't create a Contacts backend thus the Contacts app never fetches these contacts. However #8951 creates a Contacts backend, so the contacts are fetched by the contacts app.

TL;DR this PR creates the contacts, but the Contacts app doesn't fetch them. (but the Chat app does) And #8951 creates the contacts and the Contacts is able to fetch them.

[LEDfan]

@jancborchardt which PR should be used then?

[enoch85]

👍 Nice!

[LukasReschke]

This returns only false.

[nickvergessen]

Should return an empty array to match the interface

[scrutinizer-notifier]

The inspection completed: 10 new issues, 29 updated code elements

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/6395/

[LEDfan]

Can this be merged? @DeepDiver1975 Can this be backported to 7.0.1? This way I can release a beta for the Chat app without the need for people to use the git version.

[jancborchardt]

Yep @LEDfan @LukasReschke @DeepDiver1975 it would be really good if we can have this merged and in 7.0.1.

[DeepDiver1975]

it would be really good if we can have this merged and in 7.0.1.

@karlitschek has to decide on this
Personal vote: go for it

[karlitschek]

Ok. Please backport

[DeepDiver1975]

will do later ...

[DeepDiver1975]

stable7: 02a61c0

[DeepDiver1975]

@LEDfan @jancborchardt go go go! 😉

[LEDfan]

Thanks @DeepDiver1975 !

[jancborchardt]

Awesome!