Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use web client to load oCIS files and spaces #201

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Apr 14, 2023

Refs #194

@LukasHirt LukasHirt marked this pull request as ready for review April 14, 2023 14:07
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, thank you!

Found some issues, see comments.

web-client seems to be initialized with the current access token and then never updated. Means once the token renewal happened the web-client (at least for webdav I had the issue) still has the old access token and hence failing requests.

src/services/auth.ts Outdated Show resolved Hide resolved
src/components/SpacesList.vue Outdated Show resolved Hide resolved
src/components/SpacesList.vue Outdated Show resolved Hide resolved
src/components/SpacesList.vue Outdated Show resolved Hide resolved
src/components/FilePicker.vue Outdated Show resolved Hide resolved
src/components/ListResources.vue Outdated Show resolved Hide resolved
src/components/ListHeader.vue Outdated Show resolved Hide resolved
src/components/FilePicker.vue Show resolved Hide resolved
@LukasHirt LukasHirt requested a review from kulmann April 18, 2023 13:36
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to test the latest changes, I get a basic auth popup upon trying to load the page at https://host.docker.internal:3000 in the ocis example 🙈

@LukasHirt
Copy link
Contributor Author

Not able to test the latest changes, I get a basic auth popup upon trying to load the page at https://host.docker.internal:3000 in the ocis example 🙈

@kulmann I have tried to reproduce this but hasn't been successful. After opening the URL I see the login button just fine without any basic auth... I went through the code to see if there is something that could trigger it but did not see anything.

I guess we might need some debugging session together to see it happening and figure out what caused it?

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job! ❤️
Thanks for also removing the uikit assets again :-)

@kulmann
Copy link
Member

kulmann commented Apr 19, 2023

Not able to test the latest changes, I get a basic auth popup upon trying to load the page at https://host.docker.internal:3000 in the ocis example 🙈

@kulmann I have tried to reproduce this but hasn't been successful. After opening the URL I see the login button just fine without any basic auth... I went through the code to see if there is something that could trigger it but did not see anything.

I guess we might need some debugging session together to see it happening and figure out what caused it?

needed to clear site data in the application storage of the browser -.-

@kulmann kulmann merged commit 1b27245 into owncloud:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants