feat: bring back shadowRoot #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
feat/bring-back-shadow-root
branch
from
73fe5cb
to
92819f4
Compare
kulmann
reviewed
Jun 27, 2023
src/style.css
Outdated
| @@ -1,5 +1,7 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:wght@300;400;600;700&display=swap'); | |||
There was a problem hiding this comment.
Please don't fetch the font directly from google but embed it here in the repo. Or even better: import it from the design system. we've switched from source sans pro to inter a while ago. At least for web. Would make sense to do the same here and would make the import from ods easy.
There was a problem hiding this comment.
Done - I am copying only the css file now as the link into the head is inserted automatically.
LukasHirt
force-pushed
the
feat/bring-back-shadow-root
branch
from
92819f4
to
c3af85a
Compare
LukasHirt
force-pushed
the
feat/bring-back-shadow-root
branch
from
c3af85a
to
4690b84
Compare
kulmann
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since some of the styles used in the File picker can have an effect on the parent document, it is needed to handle the styles inside of shadowRoot and have them isolated.
One challenge though - vite does not inject styles into the built bundle when library mode is used in the config (open issue here vitejs/vite#1579). This of course brings the problem of including the style inside the shadowRoot. Some plugins exists that can still handle the injection but unfortunately does not work with custom elements as it anyway tries to add the styles into the document instead of shadowRoot. This forces us to append the styles ourselves into the shadowRoot when the custom element is being constructed.
This change does not affect the lib build as the style.css file is still there and can be imported manually in a scoped context.
Theming will be handled via CSS custom properties.