Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ods #36

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Update ods #36

merged 3 commits into from
Apr 28, 2021

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Apr 21, 2021 •
edited
Loading

@LukasHirt LukasHirt self-assigned this Apr 21, 2021
pascalwengerter
pascalwengerter reviewed Apr 23, 2021
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
pascalwengerter
pascalwengerter requested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ODS var & CSS selector need to be adjusted, two more small questions

@LukasHirt LukasHirt marked this pull request as ready for review April 27, 2021 11:17
@LukasHirt LukasHirt mentioned this pull request Apr 27, 2021
Open
kulmann
kulmann reviewed Apr 28, 2021
View reviewed changes
package.json Show resolved Hide resolved
@LukasHirt
Copy link
Contributor Author

LukasHirt commented Apr 28, 2021 •
edited
Loading

ODS var & CSS selector need to be adjusted, two more small questions

All have been addressed - everything was a leftover and has been removed 😁 Can you pls re-review? 🙏 @pascalwengerter

kulmann
kulmann approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pascalwengerter
pascalwengerter requested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't run it locally but code looks good so far :) do you want to bump ODS to 6.2.0 (most current version and nothing that affects your code AFAIK) for even more features?

changelog/unreleased/enhancement-update-ods Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-update-ods Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-update-ods Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@LukasHirt @kulmann
tests: remove snapshots
db9036e 
Co-authored-by: Benedikt Kulmann <[email protected]>
@LukasHirt
Copy link
Contributor Author

@pascalwengerter Updated to the latest version

pascalwengerter
pascalwengerter approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock'n'roll 🥁

@LukasHirt LukasHirt merged commit 74819b1 into master Apr 28, 2021
@LukasHirt LukasHirt deleted the deps/update-ods branch April 28, 2021 10:31
@LukasHirt LukasHirt mentioned this pull request Apr 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use oc-table component from latest ODS
3 participants
@LukasHirt @kulmann @pascalwengerter