Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding proper travis integration #1

Merged
merged 4 commits into from
Nov 23, 2014
Merged

Adding proper travis integration #1

merged 4 commits into from
Nov 23, 2014

Conversation

DeepDiver1975
Copy link
Member

basic travis integration is done - ready to merge - failing unit tests have to be fixed by @VicDeo

@DeepDiver1975 DeepDiver1975 force-pushed the adding-travis branch 5 times, most recently from 8f8291d to 8449765 Compare November 14, 2014 11:48
@DeepDiver1975
Copy link
Member Author

@VicDeo seriously - did these unit tests ever work?

@DeepDiver1975
Copy link
Member Author 

onfiguration read from /home/travis/build/owncloud/core/apps/files_antivirus/tests/phpunit.xml

FF

Time: 8.15 seconds, Memory: 39.75Mb

There were 2 failures:

1) Test_Files_Antivirus_Scanner::testScanFile

Failed asserting that '-1' matches expected 0.

/home/travis/build/owncloud/core/apps/files_antivirus/tests/scannertest.php:72

2) Test_Files_Antivirus_Status::testParseResponse

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'unknown'

+'No matching rules. Please check antivirus rules.'

/home/travis/build/owncloud/core/apps/files_antivirus/tests/statustest.php:42

FAILURES!

Tests: 2, Assertions: 10, Failures: 2.

@DeepDiver1975 DeepDiver1975 changed the title [WIP] Adding proper travis integration Adding proper travis integration Nov 14, 2014
@VicDeo
Copy link
Member

VicDeo commented Nov 14, 2014

@DeepDiver1975 Loooooong time ago.
oc_files_antivirus_status_AI_PK is too long for Oracle.
What do you think about renaming the app tables to *dbprefix*antivirus_smth or *dbprefix*files_avir_smth?

@DeepDiver1975
Copy link
Member Author

files_avir

sounds reasonable - thx - please keep migration in mind to copy over data from the old table to the new - THX

@VicDeo
Copy link
Member

VicDeo commented Nov 17, 2014

@DeepDiver1975

sounds reasonable - thx - please keep migration in mind to copy over data from the old table to the new

If the DB schema still have oc_files_antivirus_status tests won't pass. From the other hand it is needed as a data source.

Should I dump the table into a file inside the preupgrade script and restore the data from this file when the new table is ready?

@DeepDiver1975
Copy link
Member Author

If the DB schema still have oc_files_antivirus_status tests won't pass. From the other hand it is needed as a data source.

why? unit test have to run in a predefined environment..

The migration should rename the existing table - as far as possible with the given dbms

@DeepDiver1975
Copy link
Member Author

@VicDeo can we please gain some momentum on this? THX

@VicDeo
Copy link
Member

VicDeo commented Nov 21, 2014

@DeepDiver1975 yes, sir!

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 yes, sir!

great - thx 👍

DeepDiver1975 added a commit that referenced this pull request Nov 23, 2014
@DeepDiver1975
Merge pull request #1 from owncloud/adding-travis
880aa3c 
Adding proper travis integration
@DeepDiver1975 DeepDiver1975 merged commit 880aa3c into master Nov 23, 2014
@DeepDiver1975 DeepDiver1975 deleted the adding-travis branch November 23, 2014 16:52
@jnfrmarks jnfrmarks mentioned this pull request Jun 26, 2015
Closed
RostC pushed a commit that referenced this pull request Oct 9, 2015
@grischdian
Merge pull request #1 from RostC/RostC-patch-1
aed8076 
change recipient name if user_ldap is used
@Dubi01 Dubi01 mentioned this pull request Jul 8, 2016
Closed
@CyberFred-CP CyberFred-CP mentioned this pull request Oct 10, 2023
Closed
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VicDeo VicDeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @VicDeo