Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable10 migrations #170

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Stable10 migrations #170

merged 3 commits into from
Aug 16, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Aug 11, 2017

❗ this PR adds dependency on ownCloud 10.0.3+

Backport of #169

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

@VicDeo please fix failures on travis

@PVince81
Copy link
Contributor

restarted build

@VicDeo
Copy link
Member Author

VicDeo commented Aug 16, 2017

@PVince81
the error is

App "Antivirus App for files" cannot be installed because the following dep
endencies are not fulfilled: ownCloud 10.0.3 or higher is required.

@PVince81
Copy link
Contributor

ok, I'll increase the version on master...

@@ -1,11 +1,4 @@
<?php

$app = new \OCA\Files_Antivirus\AppInfo\Application();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this got removed on purpose, obsolete ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81 moved into migration.
install script is triggered before migrations, thus here we were trying to insert default rules into the table that did not exist.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 0b967ac into stable10 Aug 16, 2017
@PVince81 PVince81 deleted the stable10-migrations branch August 16, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants