Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable proxies #8

Merged
merged 2 commits into from
Jan 14, 2015
Merged

Disable proxies #8

merged 2 commits into from
Jan 14, 2015

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jan 12, 2015

No description provided.

@DeepDiver1975
Copy link
Member

Please add clover.xml to gitignore and do not check it in - THX

@VicDeo VicDeo force-pushed the fix-test branch 2 times, most recently from 1449d7f to 59fc382 Compare January 12, 2015 15:26
@DeepDiver1975
Copy link
Member

Please add clover.xml to gitignore

Did you miss to add .gitignore ? THX

@VicDeo
Copy link
Member Author

VicDeo commented Jan 12, 2015

@DeepDiver1975 well, I can make it pass now, but the faulty piece is https://github.com/owncloud/core/blob/master/apps/files_encryption/lib/proxy.php#L64

Not every path has $parts[2]. e.g. /foo.txt or /user/foo.txt hasn't

@DeepDiver1975
Copy link
Member

@schiesbn can you please have a look - THX

@schiessle
Copy link

Maybe we the proxy should check the number of path elements. But can you, @VicDeo, explain to me on what files the antivirus app operates to get a better understanding of the overall problem. The path at the proxy should always start at data/, does the antivirus app operates on files outside of data/<user>/files ?

@nickvergessen
Copy link
Contributor

prepared a patch for it in owncloud/core#13285

@VicDeo
Copy link
Member Author

VicDeo commented Jan 12, 2015

@schiesbn not exact, unit tests use temporary storage that is mounted to the user root directory

@VicDeo
Copy link
Member Author

VicDeo commented Jan 12, 2015

@nickvergessen thanks! 🍦

@nickvergessen
Copy link
Contributor

@VicDeo since my patch got merged, you just need to rebase it here.

@VicDeo
Copy link
Member Author

VicDeo commented Jan 13, 2015

Tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants