Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-4 and public API #9

Merged
merged 2 commits into from
Nov 21, 2016
Merged

Use PSR-4 and public API #9

merged 2 commits into from
Nov 21, 2016

Conversation

PVince81
Copy link
Contributor

Port this to use the public API for registering the backend.
Goal is to make it work without files_external once owncloud/core#25422 is done.

@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991 and @DeepDiver1975 to be potential reviewers

@PVince81
Copy link
Contributor Author

@DeepDiver1975 can you help with with PSR-4 ? For some reason it can't find the Application class:

{"reqId":"PCg7VpZKMMKaNhz5RNf+","remoteAddr":"127.0.0.1","app":"PHP","message":"Class 'OCA\\Files_External_Ftp\\AppInfo\\Application' not found at \/srv\/www\/htdocs\/owncloud\/apps3\/files_external_ftp\/appinfo\/app.php#3","level":3,"time":"2016-09-14T09:33:34+00:00","method":"GET","url":"\/owncloud\/index.php\/settings\/admin","user":"admin"}

@PVince81
Copy link
Contributor Author

Never mind... the namespace must be "Files_external_ftp"

@PVince81
Copy link
Contributor Author

Note: the setting "username" has to be renamed to "user" to match what the password auth delivers, do we need a migration ?

@DeepDiver1975
Copy link
Member

Note: the setting "username" has to be renamed to "user" to match what the password auth delivers, do we need a migration ?

I'd say yes ...

@PVince81
Copy link
Contributor Author

PVince81 commented Oct 5, 2016

Bäh... I switched it back to "built-in" so we don't have to provide a migration yet.

What I did though is also adjust the namespaces to work against the new core-based external storage API. So this PR requires owncloud/core#25422 to work. And it also works if the "files_external" app is disabled on that branch.

@PVince81
Copy link
Contributor Author

The core PR was merged, rebased.

@PVince81 PVince81 added this to the 9.2 milestone Nov 21, 2016
@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 50a62b8 into master Nov 21, 2016
@DeepDiver1975 DeepDiver1975 deleted the public-api branch November 21, 2016 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants