-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PSR-4 and public API #9
Conversation
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991 and @DeepDiver1975 to be potential reviewers |
@DeepDiver1975 can you help with with PSR-4 ? For some reason it can't find the Application class:
|
Never mind... the namespace must be "Files_external_ftp" |
a1e4def
to
0e9dada
Compare
Note: the setting "username" has to be renamed to "user" to match what the password auth delivers, do we need a migration ? |
I'd say yes ... |
Bäh... I switched it back to "built-in" so we don't have to provide a migration yet. What I did though is also adjust the namespaces to work against the new core-based external storage API. So this PR requires owncloud/core#25422 to work. And it also works if the "files_external" app is disabled on that branch. |
The core PR was merged, rebased. |
👍 |
Port this to use the public API for registering the backend.
Goal is to make it work without files_external once owncloud/core#25422 is done.