Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added bug demo test for removing systemtags app from whitelist for guest users #559

Merged
merged 2 commits into from
Apr 18, 2023
Merged

[tests-only][full-ci]added bug demo test for removing systemtags app from whitelist for guest users #559

merged 2 commits into from
Apr 18, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

Description

This PR adds bug demonstration test for removing systemtag app from whilelist for guest users, so that guest user cannot add, remove or view tags of a resource.

Related Issue

Related to issue: #551

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test added

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PrajwolAmatya PrajwolAmatya self-assigned this Apr 3, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Apr 4, 2023
Open
SagarGi
SagarGi reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PrajwolAmatya PrajwolAmatya force-pushed the add-test-for-remove-systemtags-from-whitelists branch from 5c22b84 to a60deb8 Compare April 4, 2023 09:39
grgprarup
grgprarup reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM 👍

@PrajwolAmatya PrajwolAmatya force-pushed the add-test-for-remove-systemtags-from-whitelists branch from a60deb8 to a19749e Compare April 5, 2023 03:55
amrita-shrestha
amrita-shrestha reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PrajwolAmatya PrajwolAmatya force-pushed the add-test-for-remove-systemtags-from-whitelists branch 2 times, most recently from 90cfaba to 4375863 Compare April 11, 2023 10:32
@PrajwolAmatya PrajwolAmatya force-pushed the add-test-for-remove-systemtags-from-whitelists branch from 4375863 to 0e53490 Compare April 12, 2023 06:18
@phil-davis phil-davis self-requested a review April 18, 2023 09:03
phil-davis
phil-davis approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. During the development of the fix, the developer and QA etc can sort out if these system-tag requests by the guest should return 403 (forbidden) or 404 (not found), and adjust the scenario steps as needed.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit fc3f092 into master Apr 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-remove-systemtags-from-whitelists branch April 18, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@SagarGi SagarGi SagarGi left review comments

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrajwolAmatya @phil-davis @grgprarup @SagarGi @amrita-shrestha