-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296
Conversation
…pace for the logo image
Co-authored-by: Michael Stingl <[email protected]>
* Remove old PLIST examples * move ownCloud.online theme + assets * move EMM assets * Adjust Fastfile for moved themes + assets * updated to Xcode 14.3 * move all app resources to the correct place in one copy command * updated to 14.3.1 --------- Co-authored-by: Michael Stingl <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>
- added accessibility label to the logo image
- add support for RGBA hex values to CSS
…screen background (#1264) * - add background image to welcome screen - add support for RGBA hex values to CSS * Assets.xcassets/AppIcon.appiconset generated with fastlane * align icon name with branding --------- Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: Michael Stingl <[email protected]>
…cords for colors, incl. a set of system colors - ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object
- add permanent logo branding to top of the view - make branding elements use same CSS selectors as welcome screen - ComposedMessageView: make CSS selectors extension public - RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode
…uld fix crash reported in #1245 (comment))
…into milestone/12.0.3
…lor and label was not readable, if lightBrandColor was similar to #000000
…ErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method
…alue could be determined for the first time (fixing crash/finding 8 in #1274)
- change officeFileFillColor to documentFileFillColor
…s folder in the share sheet picker view
ownCloudAppShared/Client/Account/Controller/AccountController.swift
Outdated
Show resolved
Hide resolved
…swift Co-authored-by: Felix Schwarz <[email protected]>
(1)Menu is only expanded the first time. Follow these steps:
Current: menu not expanded: RPReplay_Final1701765477.MP4Expected: menu expanded, no matter hay many times iPhoneXR v17.2 cc @hosy |
@felix-schwarz could you have another 👀 ? |
…lectionViewAction - CollectionViewAction: add missing parts in implementation for .expand() to expand cells, add status awareness (double expansion collapses them again) - CollectionViewSection: check cell expansion status before expanding the cell (double expansion collapses them again)
|
@hosy @michaelstingl @jesmrec I fixed issue (1) in ecf3610 |
Checked the fix, please take a look to the following video ( taken with RPReplay_Final1702462392.MP4
I tested many times, and also worked fine in some of then. Not sure if there are kind of race condition or similar that causes such weird effect. If logs or any other info helps, i will catch. Tested with iPhoneXR 17.2 |
- add new option .allowHidingNavigationBar to allow fine-tuning hiding of navigation bar (fixes optical issue when using ClientLocationPicker within the app, while allowing customization through ShareExtensionViewController) - apply same fixes to setting up sectionDataSource as were previously applied for the app's sidebar - ShareExtensionViewController: - add minor delay before opening single account connection - make use of ClientLocationPicker.allowHidingNavigationBar to force navigation bar even on first level - AccountController: clean-up and optimizations
works much better, but i still see that is not totally correct. Sometimes is not expanded RPReplay_Final1702462392.mp4
|
Superseded by changes in #1320. |
Description
Related Issue
https://github.com/owncloud/enterprise/issues/6134
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: