Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra check in release checklist, to avoid missing translations #640

Merged
merged 2 commits into from
May 25, 2020
Merged

Add extra check in release checklist, to avoid missing translations #640

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d07360f
add extra check in release checklist, to avoid missing translations i…
jesmrec Mar 5, 2020
7939b4a
Merge branch 'master' into fix/add_check_missing_translations_template
hosy May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/release_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
<!--
This is the template to release a new version on the App Store
-->
---
name: Release
about: List of checklist to accomplish for the ownCloud team to finish the release process
Expand All @@ -18,6 +15,7 @@ Release a new version
- [ ] [GIT] Create branch `release/[major].[minor].[patch]` (freeze the code)
- [ ] [DEV] Update `APP_SHORT_VERSION` `[major].[minor].[patch]` in [ownCloud.xcodeproj/project.pbxproj](https://github.com/owncloud/ios-app/blob/master/ownCloud.xcodeproj/project.pbxproj)
- [ ] [TRFX] Update translations from transifex branch.
- [ ] [TRFX] Check for missing translations. Ping @cscherm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this step is too late in the release template. As you can see, we have above the check to update the translations from Transifex.
In my opinion this task should be added to the PR template for every PR. The developer have to check, if every string was added to the localizable.strings and after this step the developer should ping all possible translators to check Transifex for missing strings -> DE: @hosy, @ChrisEdS RU: @mneuwert ES: @jesmrec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hosy If we do that for every PR, translators in the team will have to translate X times during the same version (a bit bothering). I think it 'd be better to make all the translations together just before the release (you can decide in which moment). Otherwise, every PR with new strings will be blocked till everyone translates to his language. This is my opinion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesmrec ok, you are right. What do you think about to add a checkbox to the PR template to ping translators, that new strings for translations are available (optional)?
Maybe it would be cool, if Transifex could automatically notify a Rocket Chat channel that new translations are available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

- [ ] [DIS] Update [changelog](https://github.com/owncloud/ios-app/blob/master/CHANGELOG.md)
- [ ] [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
- [ ] [QA] Design Test plan
Expand Down