[milestone/1.4] Milestone 1.4 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- adapt BookmarkViewController to latest OCBookmarkManager usage patterns - improve Illustrator ".ai" support - override for failing iOS MIMEType -> UTI conversion in FileProvider (-> fix grayed out items in Files app) - add "application/illustrator" mime type to PDFViewerViewController to allow viewing Illustrator files in-app - improved sorting - replace "type" with "kind" to match Files app and change method: - sort by type (folder / file) - if identical: sort by suffix (with fallback to MIMEType if no suffix is available) - if identical: use "_various" for comparison
Change shall avoid upload of duplicated photos since e.g. modificationDate can change if the photo was edited. Co-authored-by: Michael Neuwert <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>
* Document task scheduling This relates to #484 and owncloud/docs#1900 task scheduling This relates to #484 and owncloud/docs#1900. * Document task scheduling This relates to #484 and owncloud/docs#1900 task scheduling This relates to #484 and owncloud/docs#1900. * Update docs/modules/ROOT/pages/ios_task_scheduling.adoc Co-Authored-By: Phil Davis <[email protected]> * Update docs/modules/ROOT/pages/ios_task_scheduling.adoc Co-Authored-By: Phil Davis <[email protected]> * Changed documentation to reflect changes in instant photo upload Co-authored-by: Matthew Setter <[email protected]> Co-authored-by: Matthew Setter <[email protected]> Co-authored-by: Matthew Setter <[email protected]> Co-authored-by: Phil Davis <[email protected]> Co-authored-by: Michael Neuwert <[email protected]>
#673) * #671 Improve creation of public link - enable dragging public link - added clear button on public link name - copy link to clipboard, after link was created * - added in-app notifications to the app - show a notification if a public or private link was copied to the clipboard * implemented own notification banner class to show in-app notifications without a need of local notification permissions * resolved crash * - implemented own animator class - renamed class - added completion handler on dismissal - added shadow
* #654 bring back the round shape to the button, after changes in super class * added a new enum type to set corner radius with enum values
* - add "Show folders at the top" option in Settings - fix DisplaySettings change propagation within the same process (relevant when using multiple scenes on iPadOS) - restructure SortMethod and add support to show folders at the top for all sort methods * - Update CONFIGURATION.md to include new and previously undocumented configuration options
* Resign script with instructions how to resign an IPA file with an other certificate and provisioning profiles * Using correct markdown format * changed formatting for better readability * Updated readme file * changed new lines * changed formatting * changed formatting * changed wording * - changed folder structure - added a parameter check for the signing method * - show available certificate identities in usage - check provisioning profiles fingerprint if matches with signing identity fingerprint
* Adapted to latest SDK changes in develop branch * Implemented support for private links - Support for opening links using custom URL scheme owncloud:// - Support for associated domains added - Test associated domain configured * Some small fix for presenting linked item * Fixed an issue with universal links not being opened if the app was terminated in iOS13 * Triggering item download if necessary when core connection status changes to online * Added a comment requested in code review * Fixed build issues * Iterating through multiple bookmarks possibly related to same URL * Fixed review finding * Fixed various swift Lint findings * Fixed minor swift lint warnings * - Licensing: add finishTransaction call for SKPaymentTransactionStateRestored transactions * Fixes an issue with private link not being opened This would happen in case user has kept opened a card with actions (via 3 dots button) * Removed dead code and ensured that no item is opened at next launch if user returns to server list * Handling going back in state restoration * Added error message in case link can’t be resolved * Swiflit trailing space warnings fixed * - Update SDK to resolve issues * Made download dependant on state of the connection More reliable download mechanism for file previews: - Trigger download only if network connectivity is available - React to connection state changes * Fixed an issue with owncloud:// schemed links not opened * Trying to trigger download when network becomes available * Fixed swift lint warning * Avoiding multiple update of display view state * Updated to the latest SDK * Fixed an issue with DispatchGroup.leave() sometimes not being called * Adapted for a new connection status .connecting * Some swift lint warnings fixed * Some refactoring in the DisplayViewController * Tried to make DisplayViewController more maintenance friendly - Code restructuring - Handling of connection status - Re-worked view state handling - Tried to unwind some deeply nested hard to understand if conditions * Included a fix in the SDK which brings back missing parent OCItems * Showing “Connecting…” before OCCore switches connection status to online * Several small changes * Improved private link handling - Refactored to avoid unnecessary code duplication - Improved error messages - Showing progress HUD while link is being resolved since it might take time espeially with multiple configured bookmarks and so on * Updated to the develop/latest SDK revision * Changed how error message is chosen if the item for private link is not found * Using OCCoreConnectionStatusSignal instead of OCCore.connectionStatus * Fixed “Connecting…” visual glitch and added spinner shown while connecting * Fixed opening of app registered scheme on iOS13 As well as eventually a bug concerning file imports in case the app was not launched * Added a delay for iOS 12.x for the private link resolution So when the root view controller is instantiated it might already start some operations like opening a root of bookmark etc. Otherwise it would probably require some complex coordination managed centrally. On iOS 13 such hack would be unnecessary since there UIApplicationDelegate callbacks are not used anymore. * Improvement for QA finding If the bookmark to which private link has pointed is not configured, wrong error message has been shown * Fixed an issue with incorrect error message being shown In case item was removed * Fixed an issue with file previews - Not downloading by default if file can’t be previewed - Downloading and opening files which can be previewed by QLPreviewController * Fixed an issue with renderSpecificView() called at inapropriate time Co-authored-by: Michael Neuwert <[email protected]> Co-authored-by: Felix Schwarz <[email protected]>
* Set accessibility properties on the actions menu drag handle * Fixed accessibility label for the favorite / unfavorite button * Fixed wrong order of accesibility labels for star button (favorite) * Added accesibility label for button activating multiple item selection * Added proper accessibility labels to the toolbar items * added mouse pointer hover effect to drag view Co-authored-by: Michael Neuwert <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>
…r this small view on the iPad
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
==========================================
- Coverage 22.02% 20.04% -1.99%
==========================================
Files 355 359 +4
Lines 27821 24998 -2823
==========================================
- Hits 6127 5010 -1117
+ Misses 21694 19988 -1706
Continue to review full report at Codecov.
|
* First draft of take photo and upload feature * Don’t allow image editing when taking new pic * Next iteration of “Take photo or video” - Preserving image meta-data - Conversion HEIC -> JPEG depending on media upload settings - Conversion MOV -> MP4 - Localized action name * Fixed media naming and added some error logs * Some cosmetic code changes * Changed keyboard shortcut to Cmd+Shift+3 * Added logs to camera upload action * Added progress hud in case photo / video export would take longer * Added more logs * Added a check for HEIC support Warning added to the log in case HEIC is not supported Co-authored-by: Michael Neuwert <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>
- add Xcode scheme env var templates to simplify testing
* Correct some typos (#620) Fix small errors in typos Co-authored-by: Matthias Hühne <[email protected]> * add extra check in release checklist, to avoid missing translations in some languages (#640) Co-authored-by: Matthias Hühne <[email protected]> * Fix docs build errors (#666) Co-authored-by: Matthias Hühne <[email protected]> * #717 Implemented a contextual menu for the file list which includes the same items as the more menu card * - UIMenu title removed - use table row label color as image tint color (UIMenu background color is wrong in simulator and dark mode) * solved tint color problems for UIAction icon * fixed wording and localization Co-authored-by: Carlos Damken <[email protected]> Co-authored-by: Jesús Recio <[email protected]> Co-authored-by: Matthew Setter <[email protected]>
- Do not embed entitlements into library binaries when signing frameworks. Otherwise leading to validation issue with AppStore Connect. - Set NSExtensionFileProviderDocumentGroup to appropriate app group. This was missing Co-authored-by: Michael Neuwert <[email protected]>
Delete tmp.plist after it is no longer being used, otherwise leads to ITMS-90048 Bundle is invalid.
* Improved various aspects of media uploads - Changed a way how assets are exported which photo uploads significantly faster - Refactored PHAsset+Upload.swift extensions which is now way more readable. - Improved naming of assets - Changed default naming of uploaded assets to the scheme legacy app was using - Added an option allowing to preserve “original” asset names as used by iOS photo library - Prepared code for future enhancments (exporting additional assets like RAW images and live photo video clips * Localization of strings and other tiny changes * Made a mechanism deriving original media asset name more reliable * Fixed requesting image data * Using PHAsset.creationDate as lastModifiedDate when uploading media asset The timestamp is then set into corresponding property in the WebDAV request allowing to have proper file creation date when uploaded to oC server instance. * Picking edited version of the photo when uploading by default * Moved files around to have a cleaner structure in Xcode * Using PHAssetResourceManager for export whenever possible * Fixed small issues * Corrected some comments * Fixes issue (1) found in QA testing Fixed duplicated .MP4 extension when uploading videos Co-authored-by: Michael Neuwert <[email protected]> Co-authored-by: Felix Schwarz <[email protected]>
- add additional env parameters for logging, auth methods
…cate issue, eliminating redundant issues, respecting and remembering choices to either retry or put the connection offline
* - FileProvider: extend hardcoded MIME/Suffix -> UTI maps so files of these types are properly displayed in the Files app * - add new ItemContainer protocol allowing the retrieval of an item from another object - UIImageView+Thumbnails - fix item version comparison for thumbnails requested from the SDK (using ItemContainer) - add item version comparison for thumbnails generated locally via QLThumbnailGenerator (using ItemContainer) * - Update SDK
- only show sharing items, if sharing is enabled and core is online
…undle id, because if it is changed, the app will crash when trying to load the bundle resources)
- added new string for multiselect on iPad
- add isVolumePurchase property to provide alternative behaviour for VPP purchased copies - .purchasesAllowed now returns NO if isVolumePurchase returns YES - attempting purchases when isVolumePurchase returns YES brings up a new error message - ProgressHUDViewController - fix unwanted vertical movement of overlay
… into milestone/1.4
… phase - create folder intent was changed to placeholder completion handler
- fixed translation - removed beta warning - updated release notes
… in UserDefaults.shared) to OCAppIdentity.shared.userDefaults (fixing (5) in #716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collection of all milestone 1.4 issues
Related Issue
#716
#670
Motivation and Context
Next release 11.4
Before merging into master
ownCloud/Resources/Theming/Branding.plistbefore merging!How Has This Been Tested?
Types of changes
Checklist: