market - 0.6.0

[HanaGemela]

Reason

• Release needed for
• Drop start trial functionality #572
• Drop login button #573
• Update libraries

Product approval

• Ping pmaier to check info.xml description and screenshot
• Get approval on translations from pmaier

QA

• Generate Changelog
• Create QA Milestone and set the description to $version
• Move items from development to qa
• Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ... - no commits in last two months
• Create release branch with the format "release-$version"

Documentation

• Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

• Ping @owncloud/marketing

Build

All actions to be done on the release branch from here:

• Bump version in info.xml (no version suffix)
• Check php version dependency in info.xml
• Check minimum ownCloud version dependency in info.xml
• Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

• Create github tag for v${version}RC1 on release branch
• Build and sign RC tarball from github tag v${version}RC1 (see
  handbook for how to build)
• Upload as Github release using changelog entries
• Test and document in testplan => @davitol Tracking Testing results for Market 0.6.0 #577

Final

• Check that no documentation issues are pending
• Rename last RC tarball to final
• Create github tag for final v${version} on release branch
• Upload as Github release using changelog entries

Publishing

• Upload tarball to marketplace (see handbook for details)
• Publish tarball for customers (see handbook for details) - https://customer.owncloud.com and https://portal.owncloud.com
• Send mail to release-coordination with link to this ticket and to the changelog
• Copy email to rocket chat #updates channel

Post-release

• Rename QA milestone to $version
• Add a new 'Unreleased' section in CHANGELOG.md
• Create PR to merge changes back to the master branch with
  description "Closes #XYZ" with the release ticket number
• Close the milestone
• Ensure release template is up to date

[HanaGemela]

@davitol RC1 https://github.com/owncloud/market/releases/tag/v0.6.0RC1

[HanaGemela]

Needs RC2/final rebuild due to #575

[davitol]

Translations: https://github.com/owncloud/enterprise/issues/3840#issuecomment-648619539

[davitol]

Enterprise key app should no longer be included in the EE bundle for 10.5 core version

[davitol]

Also should all these app be included in the EE bundle now? https://github.com/owncloud/enterprise/issues/4020#issuecomment-648234614

There are some recently bundled apps like wopi
cc @pmaier1 @micbar @IljaN

[HanaGemela]

@IljaN this has been raised to P2 as this will block the release

[IljaN]

Problem is that bundle api does not receive a version: https://marketplace.owncloud.com/api/v1/bundles.json. Market app should hide incompatible app versions client-side.

[IljaN]

@micbar I think this might be fixed if we release an enterprise_key app with max_version < 10.5

[IljaN]

But we already have an enterprise-key app released with max version 10.x ... hmhhh

[IljaN]

@HanaGemela @davitol Is the installation of key app causing any errors? Possible Problem: There is code which tries to enable the enteprprise_key app after the bundle is downloaded. Possible 💥 if no enterprise_key app is present.

[jnweiger]

@IljaN The enterprise_key app is deprecated. We must not try to install it. All remaining logic should be in core by now.

[IljaN]

I see but there are Problems ™️ :
We need to support old instances which still use the old licensing scheme. This is not possible by setting version-constraints in marketplace as the "Install bundle" dialog in the market app does not honor the version constraints for an app as the bundle itself has no version constraints. https://marketplace.owncloud.com/api/v1/bundles.json

So the only viable solution from my pov is now:

• Install the enterprise_key app anyway
• Patch market app to honor version constraints of bundled apps.

[jnweiger]

Yes, good catch!

We need to support both, 10.4.1 with enterprise-app and all the old enterprise logic, and new 10.5.x which should afaik work without enterprise-app. So second solution would be my suggestion. How much effort is that?

[davitol]

IMHO I would choose also the second option, patching market app to honor version constraints of bundled apps. Not only for EE key app issue but also for example for adding WOPI to the 10.5 bundle as it was decided

[IljaN]

From: https://marketplace.owncloud.com/api/v1/bundles.json
Version Constraint on latest enterprise_key app:

"releases": [
          {
            "platformMin": "10.0.0",
            "platformMax": "10.9999.9999",
            "version": "0.2.0",
            "url": "https://marketplace.owncloud.com/api/v1/apps/enterprise_key/0.2.0"
          },

[jnweiger]

Adding enterprise-app 0.2.0 to the current 10.5.0-complete bundle with max-version=10.4.1 and without <default_enable/> makes it appear in the diabled apps page as

Having the app there but intended for not being used, is a bit confusing. But the red message is worse. An admin must assume something is wrong.

[pmaier1]

Having the app there but intended for not being used, is a bit confusing. But the red message is worse. An admin must assume something is wrong.

The enterprise_key app should not be part of the 10.5 bundle. The logic has moved to core and the app is deprecated. That's why we re-release it with the version constraint in the first place.

[jnweiger]

@pmaier1 IIRC, the decision on Friday was to include the enterprise_key app and work on the symptoms. No?

[pmaier1]

@pmaier1 IIRC, the decision on Friday was to include the enterprise_key app and work on the symptoms. No?

If I'm not totally mistaken, the decision was to re-release it with a max-version=10.4.1 to prevent people on 10.5 from installing it from the Marketplace. Other than that 10.4.1 is the last version that includes it.

@micbar Please enlighten us :)

[micbar]

If it is possible, remove. it from the bundle for 10.5

@pmaier1 The problem is, we still need it for 10.4.1. These instances need to fetch it from the marketplace.

So we said: if we cannot make the disctinction on the marketplace, we need to keep it in the bundle.

[jnweiger]

Ok. I am not adding enterprise-key app to the bundle. we do a re-release to market place only with max-version=10.4 correct?
@IljaN would that work for you? Can you work on this p2 ?

[IljaN]

@jnweiger Not sure If I understand enteprise_key is already in the bundle on marketplace?

[davitol]

we do a re-release to market place only with max-version=10.4 correct?

10.4.1 10.4. is fine, it allows any 10.4.X version

@jnweiger Not sure If I understand enteprise_key is already in the bundle on marketplace?

Enterprise key app is currently included in the marketplace EE bundle. @jnweiger won't include enterprise key app in the apps that are included in the complete tarball.

[jnweiger]

• merge Only enable enterprise_key for versions < 10.5.0 [QA branch] #579
• prepublished https://github.com/owncloud/market/releases/tag/v0.6.0RC2
  @davitol happy testing!

[davitol]

@IljaN Testing market 0.6.0 RC2 included in ownCloud 10.5.1. RC4

Testing steps:

1 - Browse to the bundle section and install Enterprise bundle

Current behavior

A blank page appears in the browser and if you reload the browser, Internal server error is shown.

Content of owncloud.log file below

{"reqId":"4Zt5EYRabciOK9umgMVz","level":3,"time":"2020-07-14T11:20:36+00:00","remoteAddr":"172.18.0.1","user":"12345","app":"no app in context","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Exception: {\"Exception\":\"Exception\",\"Message\":\"enterprise_key can't be enabled since it is not installed.\",\"Code\":0,\"Trace\":\"#0 \\\/mnt\\\/data\\\/apps\\\/objectstore\\\/appinfo\\\/app.php(19): OC\\\\App\\\\AppManager->enableApp()\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(239): require_once('\\\/mnt\\\/data\\\/apps\\\/...')\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(190): OC_App::requireAppFile()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(124): OC_App::loadApp()\\n#4 \\\/var\\\/www\\\/owncloud\\\/ocs\\\/v1.php(58): OC_App::loadApps()\\n#5 \\\/var\\\/www\\\/owncloud\\\/ocs\\\/v2.php(23): require_once('\\\/var\\\/www\\\/ownclo...')\\n#6 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/App\\\/AppManager.php\",\"Line\":243}"} {"reqId":"4Zt5EYRabciOK9umgMVz","level":2,"time":"2020-07-14T11:20:36+00:00","remoteAddr":"172.18.0.1","user":"12345","app":"core","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Could not load app \"objectstore\", see exception above"} {"reqId":"4Zt5EYRabciOK9umgMVz","level":3,"time":"2020-07-14T11:20:36+00:00","remoteAddr":"172.18.0.1","user":"12345","app":"PHP","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Exception: enterprise_key can't be enabled since it is not installed. at \/var\/www\/owncloud\/lib\/private\/App\/AppManager.php#243"} {"reqId":"ZWCbXb7VaVn0VVjl92R9","level":3,"time":"2020-07-14T11:20:55+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"objectstore","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Enabling Enterprise license app which was deactivated."} {"reqId":"ZWCbXb7VaVn0VVjl92R9","level":3,"time":"2020-07-14T11:20:55+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"no app in context","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Exception: {\"Exception\":\"Exception\",\"Message\":\"enterprise_key can't be enabled since it is not installed.\",\"Code\":0,\"Trace\":\"#0 \\\/mnt\\\/data\\\/apps\\\/objectstore\\\/appinfo\\\/app.php(19): OC\\\\App\\\\AppManager->enableApp()\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(239): require_once('\\\/mnt\\\/data\\\/apps\\\/...')\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(190): OC_App::requireAppFile()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/app.php(124): OC_App::loadApp()\\n#4 \\\/var\\\/www\\\/owncloud\\\/ocs\\\/v1.php(58): OC_App::loadApps()\\n#5 \\\/var\\\/www\\\/owncloud\\\/ocs\\\/v2.php(23): require_once('\\\/var\\\/www\\\/ownclo...')\\n#6 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/App\\\/AppManager.php\",\"Line\":243}"} {"reqId":"ZWCbXb7VaVn0VVjl92R9","level":2,"time":"2020-07-14T11:20:55+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"core","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Could not load app \"objectstore\", see exception above"} {"reqId":"ZWCbXb7VaVn0VVjl92R9","level":3,"time":"2020-07-14T11:20:55+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"PHP","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v1\/notifications?format=json","message":"Exception: enterprise_key can't be enabled since it is not installed. at \/var\/www\/owncloud\/lib\/private\/App\/AppManager.php#243"

[IljaN]

I think the problem is within the objectstore app which tries to enable enterprise_key app which is not installed. From my POV a new release of objecstore app is required which remove the license-check from the app.

@davitol Could you please repeat the test with disabled objectstore app to verify?

[davitol]

staging enviroment needs to get the latest objectstore version 0.6.0. It is still with the old data

[davitol]

@jnweiger @HanaGemela LGTM