Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back Release 0.6.0 #581

Merged
merged 7 commits into from
Jul 15, 2020
Merged

Merge back Release 0.6.0 #581

merged 7 commits into from
Jul 15, 2020

Conversation

HanaGemela
Copy link
Contributor

Closes #574

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #581 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #581      +/-   ##
============================================
- Coverage     55.57%   55.56%   -0.02%     
- Complexity      263      264       +1     
============================================
  Files            17       17              
  Lines           923      925       +2     
============================================
+ Hits            513      514       +1     
- Misses          410      411       +1     
Impacted Files Coverage Δ Complexity Δ
lib/MarketService.php 59.32% <50.00%> (-0.08%) 84.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5d0af...477b4df. Read the comment docs.

@phil-davis
Copy link
Contributor

@micbar please merge for us. The code coverage result has to be ignored - if it is really failing a bit there is nothing we can do about it for the merge-back.

@micbar micbar merged commit 56a8e47 into master Jul 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the release-0.6.0 branch July 15, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

market - 0.6.0
5 participants