Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suggested use for major update #1230

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

prsnbrg
Copy link
Contributor

@prsnbrg prsnbrg commented May 13, 2023

Fix #1091

@CLAassistant
Copy link

CLAassistant commented May 13, 2023

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It seems that the option and argument can actually be given either way around. But suggesting putting the option first makes it match with the help format:

$ php occ market:upgrade --help
Description:
  Installs new app versions if available on the marketplace

Usage:
  market:upgrade [options] [--] [<ids>...]

Arguments:
  ids                   Ids of the apps

Options:
  -l, --local[=LOCAL]   Optional path to a local app packages (multiple values allowed)
      --major           Allow update to a new major versions
...

@phil-davis phil-davis merged commit fcfaa3d into owncloud:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] sugested usage for major update is wrong
3 participants