provide non-zero exit codes on failure #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2017
PVince81
reviewed
Sep 6, 2017
lib/Command/InstallApp.php
Outdated
| @@ -89,7 +92,8 @@ protected function execute(InputInterface $input, OutputInterface $output) { | |||
| $output->writeln("$appId: App installed."); | |||
| } | |||
| } catch (\Exception $ex) { | |||
| $output->writeln("$appId: {$ex->getMessage()}"); | |||
| $output->writeln("<error> $appId: {$ex->getMessage()} </error>"); | |||
| $this->exitCode = 1; | |||
patrickjahns
force-pushed
the
occ_exit_codes
branch
from
d8dc9ce
to
16785d7
Compare
|
please backport to stable10: submit a new PR with the same commits (cherry-pick) but to target branch "stable10" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OCC market commands would always return 0 as exit code, even if a failure occured. This PR is related to #133 to provide non-zero exit codes (exit-code 1 on failure). When a failure occured
Tested manually: