Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate cache on change of apikey / enterprise trail #282

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

patrickjahns
Copy link
Contributor

Fixes #260

When caching is active, the first request would be cached and if the apikey / enterprise trail is started afterward, it would lead to not being able to install enterprise trail apps

Note:
There is still an open scenario, that when the user changes config.php manually to update licensekey and apikey that the cache would persist.

We should document that changing/adding theses values requires a cache invalidation

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #282 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #282     +/-   ##
===========================================
- Coverage      36.1%   36.01%   -0.1%     
  Complexity      228      228             
===========================================
  Files            15       15             
  Lines           770      772      +2     
===========================================
  Hits            278      278             
- Misses          492      494      +2
Impacted Files Coverage Δ Complexity Δ
lib/MarketService.php 18.86% <0%> (-0.15%) 100 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b12f2...844cb90. Read the comment docs.

@IljaN IljaN self-requested a review March 7, 2018 11:01
@PVince81
Copy link
Contributor

@patrickjahns codecov fails, any chance to cover the new lines somehow ?

@DeepDiver1975 DeepDiver1975 merged commit ace49d7 into master Apr 3, 2018
@DeepDiver1975 DeepDiver1975 deleted the fix_invalidate_cache branch April 3, 2018 07:57
@patrickjahns
Copy link
Contributor Author

This does not solve the issue 100% -> there seems to be something going on on the marketplace side that causes a delay of propagation when a enterprise trail is started from the market app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants