Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize CI #427

Merged
merged 12 commits into from
Dec 19, 2018
Merged

Standardize CI #427

merged 12 commits into from
Dec 19, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 18, 2018 •
edited
Loading

Issue #361

@phil-davis phil-davis self-assigned this Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #427 into master will decrease coverage by 1.26%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #427      +/-   ##
============================================
- Coverage     52.84%   51.57%   -1.27%     
+ Complexity      278      255      -23     
============================================
  Files            17       17              
  Lines           931      888      -43     
============================================
- Hits            492      458      -34     
+ Misses          439      430       -9
Impacted Files Coverage Δ Complexity Δ
appinfo/app.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/Controller/MarketController.php 0% <0%> (ø) 36 <0> (-6) ⬇️
lib/Listener.php 0% <0%> (ø) 4 <1> (ø) ⬇️
lib/Controller/LocalAppsController.php 0% <0%> (ø) 5 <1> (-2) ⬇️
lib/Application.php 0% <0%> (ø) 5 <5> (-6) ⬇️
lib/Command/ListApps.php 81.25% <100%> (-6.99%) 6 <1> (ø)
lib/Command/UpgradeApp.php 95.91% <100%> (-2.2%) 26 <0> (ø)
lib/CheckUpdateBackgroundJob.php 98.14% <100%> (-0.07%) 15 <0> (ø)
lib/Command/InstallApp.php 94.59% <100%> (-2.91%) 19 <0> (ø)
lib/Command/UnInstallApp.php 92% <100%> (-4.16%) 7 <0> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c374dc...57d3b88. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Dec 19, 2018 •
edited
Loading

Edit: done in this PR
To do in a next PR:

  • sort out the composer.phar stuff that is still in Makefile
  • delete .travis.yml

skshetry
skshetry requested changes Dec 19, 2018
View reviewed changes
Copy link
Member

@skshetry skshetry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to also add test-acceptance-X(cli/api/webui) on the Makefile and use COMPOSER_BIN instead of phar. Others look good to me.

Makefile Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor Author

I added the acceptance test Makefile targets. We have not always been doing that, for apps that do not have any acceptance tests yet. But I guess it does not hurt.

@phil-davis
Copy link
Contributor Author

Travis has been deleted and I got rid of COMPOSER_PHAR.
I tried a make dist and it still does a lot of stuff and creates a tarball, so I don't think that I broke it ;)
@skshetry please review again

@phil-davis phil-davis merged commit 92e2d5a into master Dec 19, 2018
@delete-merged-branch delete-merged-branch bot deleted the standardize-CI branch December 19, 2018 09:27
@phil-davis phil-davis mentioned this pull request Dec 19, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry approved these changes

Assignees

@phil-davis phil-davis

Labels
4 - To release Drone QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @skshetry