-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App layout is totally broken on Nextcloud 14.0.0-beta3 #660
Comments
Hi, as you may have already seen, we have entered the beta phase for the release of Nextcloud 14. We usually try to keep up compatibility with previous app versions, but in some cases apps need some adjustments to properly work on new Nextcloud releases. With Nextcloud 14 there have been quite some changes in that regard: You can find a list of all critical changes for app developers and admins at nextcloud/server#7827. You can run occ app:check-code to validate that there are no issues with deprecated or private message calls. One critical change is the overall restructuring of the main template (nextcloud/server#9982) that might require some adjustments in your app. Thanks for all the effort you put into providing this app 🚀 . |
The application layout is now fully usable also on Nextcloud 14 beta and RC versions. There are still glitches but nothing show-stopping. This has been achieved by including style definitions which used to be set in the core but are no longer in NC14. Defining these in the application shouldn't affect the layout on older cloud versions. refs owncloud#660
On Nextcloud 14, the whole window is the scroll container instead of just #app-content scrolling. This required changes to the the scroll link logic. Also the alphabet navigation links were changed to scroll through the javascript function scrollToItem in the maincontroller instead of using the custom angular directives du-scroll-container and du-smooth-scroll. This way, it's easier to have different scroll logic for NC14 and other cloud versions. refs owncloud#660
On Nextcloud 14, the #app-navigation pane has width of 300px instead of the previous 250px. The width of the text input elements used to create or rename a playlist is now set according the available space. Previously, it was hard-coded to 166px which looked silly on NC14. The layout of the "New Playlist" row also used to break if scroll bar was shown on #app-navigation. Also, the layout of the confirm/cancel buttons of the said text input elements was altered slightly. The confirm button is now on the left and the cancel button on the right on the "New Playlist" row. This way, the confrim button location is the same on "New Playlist" and when renaming a playlist. If the playlist name is empty, the confirm button is now disabled instead of hiding it completely. refs #660
Nextcloud 14 no longer provides the style definition for #app-navigation .app-navigation-separator as the previous cloud versions. refs #660
On NC14, the alphabet navigation was shown too far away from the right edge of the app view. The new logic works better on NC14 and doesn't make any difference on the older cloud versions. refs #660
The embedded music player bar was too narrow on NC14 by the width of the scroll bar. Javascript files shared between the full-size app and the embedded player are now located in the folder js/shared. refs #660
In the latest versions of NC14, this style definition is no longer included in the core. refs #660
The release v0.9.1 fixes the layout on Nextcloud 14. |
The app used to work well on NC 14.0.0-alpha, but something has changed since and now everything is messed up:
The main issue seems to be that the
#app-view
element has 0-width. Smaller problems are caused by the fact that the width of#app-navigation
has been increased from 250px to 300px.The text was updated successfully, but these errors were encountered: