Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate lock in PROPPATCH in WebDAV so that Windows in default config can create/copy files #10551

Closed
wants to merge 1 commit into from

Conversation

roman-vanicek
Copy link

Description

Windows built-in WebDAV client in default configuration cannot copy/create files in ocis after mounting owncloud as a disk drive using net use D: ... This is one of two necessary changes to make it work.

Related Issue

  • another issues that otherwise block Windows WebDAV client is a name of HTTP header that contains the lock value. In previous version of ocis it used the HTTP header "If". The current version uses header "Lock-Token". I do not know the reason this has changed so it is not part of this PR. Moreover this issues can be worked around on reverse proxy by duplicating the HTTP header value.

Motivation and Context

No Windows client can use WebDAV in the default configuration on ocis and Windows.

How Has This Been Tested?

Tested on my own build that contains just this fix. No test case added.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Nov 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Nov 12, 2024

@rhafer
Copy link
Contributor

rhafer commented Nov 12, 2024

@roman-vanicek Thanks for your contribution. However your change is on a go module that we import via go mod vendor . The correct place to submit your patch is the cs3org/reva project.

Please create a PR against the edge branch of https://github.com/cs3org/reva

@roman-vanicek
Copy link
Author

I have created cs3org/reva#4928 as recommended. Closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants