Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Update expected failure after spaces tests added on apiAuthWebDav suites #3030

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[tests-only][full-ci]Update expected failure after spaces tests added on apiAuthWebDav suites #3030

merged 1 commit into from
Jan 26, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 25, 2022 •
edited
Loading

Description

This PR adjusts the expected failures files after the tests related to the spaces webDAV added in apiAuthWebDav suites.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@amrita-shrestha amrita-shrestha self-assigned this Jan 25, 2022
@amrita-shrestha amrita-shrestha changed the title Update expected failure after spaces tests added on apiAuthWebDav suites [tests-only][full-ci]Update expected failure after spaces tests added on apiAuthWebDav suites Jan 25, 2022
@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch from 628592d to 8934a6d Compare January 25, 2022 09:51
@owncloud owncloud deleted a comment from update-docs bot Jan 25, 2022
@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch 2 times, most recently from 7edba81 to 5718eb7 Compare January 25, 2022 10:22
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 25, 2022
Merged
11 tasks
kiranparajuli589
kiranparajuli589 reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch 3 times, most recently from 1973322 to 5e338d3 Compare January 26, 2022 04:35
kiranparajuli589
kiranparajuli589 reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch from 5e338d3 to d81f0e6 Compare January 26, 2022 05:40
@phil-davis
Copy link
Contributor

@amrita-shrestha this will be good. There are also new scenarios that I added in another core PR.

Have a look at PR https://github.com/owncloud/ocis/pull/3037/files and also add that to the end of expected-failures. Then we can merge this PR, and I will close #3037

@phil-davis phil-davis mentioned this pull request Jan 26, 2022
Closed
9 tasks
@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 26, 2022 06:40
@amrita-shrestha amrita-shrestha removed the request for review from phil-davis January 26, 2022 06:43
@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch from 4806135 to 67d2eed Compare January 26, 2022 06:45
@kiranparajuli589
Copy link
Contributor

@phil-davis the commit id tried to be bumped in the PR #3025 should be included here right? can we close that PR in behalf of this?

@phil-davis
Copy link
Contributor

@phil-davis the commit id tried to be bumped in the PR #3025 should be included here right? can we close that PR in behalf of this?

yes, a single commit id bump brings in all core test changes at once.

@kiranparajuli589 kiranparajuli589 mentioned this pull request Jan 26, 2022
Closed
@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Jan 26, 2022 •
edited
Loading

one of the web suites Web-Tests-ocis-ocis-storage-15 failed https://drone.owncloud.com/owncloud/ocis/8956/46/9. build restarted

@amrita-shrestha amrita-shrestha force-pushed the adjust-apiAuthWebdav-expected-failure branch from 67d2eed to 32ea08e Compare January 26, 2022 07:23
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

@amrita-shrestha please make similar commit-id bump PRs for cs3org/reva branches master and edge.

There will not be so many changes needed to expected-failures in cs3org/reva because we are not yet running the personalSpace scenarios there. I am currently looking at that separately.

@phil-davis phil-davis merged commit cca0fd5 into master Jan 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the adjust-apiAuthWebdav-expected-failure branch January 26, 2022 08:23
@phil-davis phil-davis mentioned this pull request Jan 26, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrita-shrestha @phil-davis @kiranparajuli589