Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump core commit id to include core PR 39728 test changes #3051

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 28, 2022

Description

core PR owncloud/core#39728 has refactored the tests related to issue #3047

This PR bumps the core commit id to include the refactored test scenarios. I have added comments in issue #3047 about each scenario that fails in oCIS.

Related Issue

#3047

owncloud/core#39728

owncloud/QA#715

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

- [apiShareManagementToShares/moveShareInsideAnotherShare.feature:100](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareManagementToShares/moveShareInsideAnotherShare.feature#L100)

Note: always have an empty line at the end of this file.
The bash script that processes this file requires that the last line has a newline on the end.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last line of a test or last line in file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last line of the file

@phil-davis phil-davis merged commit a98c57e into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commit-id-39728 branch January 28, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants