Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump CORE_COMMITID to include core PR 39813 #3215

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

phil-davis
Copy link
Contributor

core PR owncloud/core#39813 enhanced the test code that checks the status.php end-point. Bump the CORE_COMMITID so that we run that code in CI.

@phil-davis phil-davis self-assigned this Feb 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Note: the status.php test still fails, and is in expected-failures. That is expected. I will now look into the exact failure, maybe I can get it to pass. The data is pretty close:

    Then the status.php response should match with # FeatureContext::statusPhpRespondedShouldMatch()
      """
      {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"$CURRENT_VERSION","versionstring":"$CURRENT_VERSION_STRING","edition":"$EDITION","productname":"$PRODUCTNAME"}
      """
      The json responded: {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.9.5","versionstring":"10.0.9","edition":"community","productname":"ownCloud"} does not match with json expected: {"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.11.5","versionstring":"10.0.11","edition":"community","productname":"reva"}
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.11.5","versionstring":"10.0.11","edition":"community","productname":"reva"}'
+'{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.9.5","versionstring":"10.0.9","edition":"community","productname":"ownCloud"}'
      

This PR can be merged - the test code changes are working.

@phil-davis phil-davis marked this pull request as ready for review February 22, 2022 09:29
@phil-davis phil-davis merged commit b192289 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-39813 branch February 22, 2022 09:57
ownclouders pushed a commit that referenced this pull request Feb 22, 2022
Merge: 228a687 fe307f1
Author: Phil Davis <[email protected]>
Date:   Tue Feb 22 15:42:52 2022 +0545

    Merge pull request #3215 from owncloud/bump-commit-id-39813

    [tests-only] [full-ci] Bump CORE_COMMITID to include core PR 39813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants