Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add api tests for tus upload when quota is set #4440

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[tests-only] Add api tests for tus upload when quota is set #4440

merged 1 commit into from
Sep 5, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 23, 2022 •
edited by kiranparajuli589
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Aug 23, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Aug 25, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@SwikritiT SwikritiT marked this pull request as ready for review August 25, 2022 09:07
@SwikritiT SwikritiT force-pushed the add-tests-quota-tus branch 2 times, most recently from 5bebe8e to 1a7bbf8 Compare August 26, 2022 06:26
grgprarup
grgprarup reviewed Aug 26, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

SagarGi
SagarGi reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

SwikritiT
SwikritiT commented Sep 5, 2022
View reviewed changes
.drone.env Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis dismissed individual-it’s stale review September 5, 2022 11:36

changes have been addressed

@phil-davis phil-davis merged commit 6f9afa8 into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-tests-quota-tus branch September 5, 2022 11:36
ownclouders pushed a commit that referenced this pull request Sep 5, 2022
@phil-davis
commit 6f9afa8
9218cf8 
Merge: fdb059c 967e7f4
Author: Phil Davis <[email protected]>
Date:   Mon Sep 5 17:21:11 2022 +0545

    Merge pull request #4440 from owncloud/add-tests-quota-tus

    [tests-only] Add api tests for tus upload when quota is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@individual-it individual-it Awaiting requested review from individual-it

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SwikritiT @ownclouders @phil-davis @individual-it @grgprarup @kiranparajuli589 @SagarGi @saw-jan