Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Api test. fix search test #4463

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[tests-only] Api test. fix search test #4463

merged 1 commit into from
Sep 5, 2022

Conversation

ScharfViktor
Copy link
Contributor

issue was closed #4014, but the failed tests still existed

  • with the existing implementation we cannot find the folder "folder" in the search response. but we still check that search result contains subfolders
  • in test we have checking that response should contain 4 entries

folder "folder" is mountpoint and looks like id
Screenshot 2022-08-26 at 08 48 31

but the other folders we can find with the existing implementation:
Screenshot 2022-08-26 at 08 49 50

@phil-davis phil-davis changed the title [test-only] Api test. fix search test [testa-only] Api test. fix search test Aug 26, 2022
@phil-davis phil-davis changed the title [testa-only] Api test. fix search test [tests-only] Api test. fix search test Aug 26, 2022
@owncloud owncloud deleted a comment from update-docs bot Aug 26, 2022
@ScharfViktor ScharfViktor added the Status:Needs-Review Needs review from a maintainer label Aug 30, 2022
@ScharfViktor
Copy link
Contributor Author

@phil-davis can you have a look it please again.

@ScharfViktor
Copy link
Contributor Author

I think we can wait #4485

@phil-davis
Copy link
Contributor

PR #4485 was merged last Friday.

@ScharfViktor I guess you need to rebase and then we can review etc.

@ScharfViktor
Copy link
Contributor Author

PR #4485 was merged last Friday.

@ScharfViktor I guess you need to rebase and then we can review etc.

I'll do it. 5 min

phil-davis
phil-davis approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@phil-davis phil-davis merged commit fdb059c into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixSearchTest branch September 5, 2022 09:55
ownclouders pushed a commit that referenced this pull request Sep 5, 2022
@phil-davis
commit fdb059c
62aa6f8 
Merge: ac0b659 6b3501b
Author: Phil Davis <[email protected]>
Date:   Mon Sep 5 15:40:36 2022 +0545

    Merge pull request #4463 from owncloud/fixSearchTest

    [tests-only] Api test. fix search test
@ScharfViktor ScharfViktor mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @phil-davis