Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix notifications config #4652

Merged
merged 3 commits into from
Sep 26, 2022
Merged

fix notifications config #4652

merged 3 commits into from
Sep 26, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Sep 23, 2022 •
edited
Loading

Description

We've fixed two notifications service setting:

  • NOTIFICATIONS_MACHINE_AUTH_API_KEY was previously not picked up (only OCIS_MACHINE_AUTH_API_KEY was loaded)
  • If you used a email sender address in the format of the default value of NOTIFICATIONS_SMTP_SENDER no email could be send.

Related Issue

Motivation and Context

How Has This Been Tested?

  • inbucket

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review September 26, 2022 06:30
dragonchaser
dragonchaser approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 6a0a96d into owncloud:master Sep 26, 2022
ownclouders pushed a commit that referenced this pull request Sep 26, 2022
@wkloucek
commit 6a0a96d
e20c586 
Merge: fcff2b1 840df9c
Author: Willy Kloucek <[email protected]>
Date:   Mon Sep 26 10:37:37 2022 +0200

    Merge pull request #4652 from wkloucek/notifications-config-fix

    fix notifications config
@wkloucek wkloucek deleted the notifications-config-fix branch September 26, 2022 08:48
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @dragonchaser