Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add curl to the oCIS OCI image #4751

Merged
merged 1 commit into from
Oct 10, 2022
Merged

add curl to the oCIS OCI image #4751

merged 1 commit into from
Oct 10, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 7, 2022

Description

  • have curl inside the container for pull requests
  • remove the apk upgrade step, since one should not alter the base image without need
  • use apk add --no-cache instead of apk update

Related Issue

Motivation and Context

having some basic tools in the image

How Has This Been Tested?

  • none

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek mentioned this pull request Oct 7, 2022
Merged
5 tasks
@wkloucek wkloucek requested a review from rhafer October 7, 2022 05:15
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 7b8669b into owncloud:master Oct 10, 2022
@wkloucek wkloucek deleted the add-curl-to-image branch October 10, 2022 09:20
ownclouders pushed a commit that referenced this pull request Oct 10, 2022
@wkloucek
commit 7b8669b
97da170 
Merge: cdd2a93 503c8a3
Author: Willy Kloucek <[email protected]>
Date:   Mon Oct 10 11:20:17 2022 +0200

    Merge pull request #4751 from wkloucek/add-curl-to-image

    add curl to the oCIS OCI image
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @rhafer